Repository navigation
Do not return the SMTP password from the notifications API - #5980
Merged
Merged
Conversation
GET /api/notifications/email returned the stored SMTP password to every caller that can read the settings. This includes the reader role and, with authentication disabled (the default), anonymous callers. The password is now write-only: - GET never returns it. - A save with an empty password keeps the stored password. ServicePulse sends its form back without a password, because it no longer receives one. - A save without an account removes the stored password. Tests: - NotificationsControllerTests (unit) cover the GET response and how each kind of save changes the stored password. - One acceptance test checks the HTTP response end to end.
dvdstelt
approved these changes
Oct 9, 2026
ramonsmits
enabled auto-merge (squash)
October 9, 2026 13:48
ramonsmits
added a commit
that referenced
this pull request
Oct 9, 2026
…5981) GET /api/notifications/email returned the stored SMTP password to every caller that can read the settings. This includes the reader role and, with authentication disabled (the default), anonymous callers. The password is now write-only: - GET never returns it. - A save with an empty password keeps the stored password. ServicePulse sends its form back without a password, because it no longer receives one. - A save without an account removes the stored password. Tests: - NotificationsControllerTests (unit) cover the GET response and how each kind of save changes the stored password. - One acceptance test checks the HTTP response end to end. (cherry picked from commit 5e2364f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
GET /api/notifications/emailreturns the stored SMTP password. Every caller that can read the notification settings can read the password. This change makes the password write-only.Change
GET /api/notifications/emaildoes not return the password.POST /api/notifications/email:Tests
NotificationsControllerTests(4 tests). They check the GET response and how each kind of save changes the stored password. Against the previous controller, the GET test and the "empty password keeps the stored one" test fail.When_email_notification_settings_contain_a_password, checks the HTTP response end to end.