Repository navigation
Do not share the broker data dictionary between usage reports - #5983
Merged
Merged
Conversation
The usage report used the broker data dictionary from the data store as its environment data, and then added its own keys to it. When no broker data is stored, the EF Core and RavenDB data stores return one static default instance. All reports in the process then write into the same dictionary. Two reports that are generated at the same time can show values of the other report. This made When_reporting_the_environment fail at random. The acceptance tests run in parallel, so the report of one test could contain the redirect count, the report mask count or the heartbeat values of another test. - The report copies the broker data into a new dictionary. - The EF Core and RavenDB data stores return a new default instance.
dvdstelt
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage report adds its environment data to the broker data dictionary from the data store. When no broker data is stored, that dictionary is one static instance, so two reports generated at the same time show each other's values. This made
When_reporting_the_environmentfail at random in the parallel acceptance tests.