Skip to content

Give the retention sweep tests a larger wait budget on slow CI runners #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonsmits merged 1 commit into from
Oct 14, 2026
Merged

Give the retention sweep tests a larger wait budget on slow CI runners #5985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ServiceControl.Persistence.Tests/EFCore/RetentionSweepTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,11 +478,18 @@ async Task<List<string>> GetRemainingMarkers()

IRetentionSweeper GetSweeper() => ServiceProvider.GetRequiredService<IRetentionSweeper>();

// The sweeps under test delete at most a few batches, so the wait returns within a second or two
// when nothing is wrong. On CI a batch delete can stall for over ten seconds, because every
// parallel test schema shares one full-text catalog and a delete on the full-text indexed table
// waits for the other tests' index DDL. The default 10 second budget lost that race, so this one
// is larger. It only costs time when the sweep is stuck.
static readonly TimeSpan SweepWaitBudget = TimeSpan.FromSeconds(60);

async Task WaitForManualSweepToFinish()
{
var sweeper = GetSweeper();
await WaitUntil(() => Task.FromResult(!sweeper.GetStatus().IsRunning),
"the manual sweep to finish");
"the manual sweep to finish", SweepWaitBudget);
}

[Test]
Expand Down
Loading