Skip to content

Consistent modals - #3162

Closed
PhilBastian wants to merge 25 commits into
masterfrom
consistent_modals
Closed

PhilBastian wants to merge 25 commits into
masterfrom
consistent_modals

Conversation

@PhilBastian

Copy link
Copy Markdown
Contributor

change all places that referenced modal.css to instead use the ModalDialog control. This ensures consistency so that all modals now have:

  • a close button on the right of the header
  • max sizing to fit within the viewport, with overflow control
  • tab capture
  • escape to close

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

@PhilBastian PhilBastian self-assigned this Oct 14, 2026
@PhilBastian

Copy link
Copy Markdown
Contributor Author

incorrect base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant