Repository navigation
Explain that the stored SMTP password is never shown - #3164
Open
ramonsmits wants to merge 1 commit into
Open
ramonsmits wants to merge 1 commit into
ramonsmits wants to merge 1 commit into
Conversation
ServiceControl no longer returns the stored SMTP password, so the password field in the email configuration is empty when the dialog opens. - The field explains that an empty password keeps the stored one. - autocomplete="new-password" stops the browser from filling in a saved password. - The dialog recommends a dedicated SMTP account with limited send permissions, and links to the documentation. - The dialog loads the settings from ServiceControl when it opens, instead of using the copy loaded with the page. It shows changes made by other users, and the stored password of older ServiceControl versions. - A save no longer copies the settings into the store, so the typed password does not stay in memory.
dvdstelt
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceControl 6.21.2 and later do not return the stored SMTP password. This PR changes the email configuration dialog to work with this. It also tells the user how to decrease the risk.
Changes
autocomplete="new-password". This stops password managers from filling in a saved password.Tests
HealthCheckNotifications.spec.ts: the dialog loads new settings when it opens, never shows the password, and shows the SMTP recommendation.HealthChecksStore.spec.ts: the store does not keep the password after a save.