Skip to content

Make the searched GitHub owners configurable and stop flooding the API #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Philipp0205 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make the searched GitHub owners configurable and stop flooding the API #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
257ae6f
Skip GitHub owner scopes the access token may not search
Philipp0205 Sep 7, 2026
4842791
Let the searched GitHub owners be configured, and stop flooding the API
Philipp0205 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 45 additions & 18 deletions ...t.pullrequest.test/src/org/eclipse/egit/pullrequest/internal/github/GitHubClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.Arrays;
import java.util.List;

import org.eclipse.egit.pullrequest.internal.github.GitHubSearchQueries.Query;
import org.junit.Test;

/**
Expand All @@ -42,32 +43,37 @@ public void testTokenOnlyClientConstruction() {

@Test
public void testAccessibleSearchCoversOwnedOrgsAndForeignRepos() {
List<String> queries = GitHubSearchQueries
List<Query> queries = GitHubSearchQueries
.accessiblePullRequestQueries("alice", //$NON-NLS-1$
Arrays.asList("acme", "friends"), //$NON-NLS-1$ //$NON-NLS-2$
Arrays.asList("alice/notes", "acme/app", //$NON-NLS-1$ //$NON-NLS-2$
"bob/tool"), //$NON-NLS-1$
null, null);

assertThat(queries, contains("is:pr user:alice is:open", //$NON-NLS-1$
"is:pr org:acme is:open", //$NON-NLS-1$
"is:pr org:friends is:open", //$NON-NLS-1$
"is:pr repo:bob/tool is:open")); //$NON-NLS-1$
assertThat(queries, hasSize(1));
assertThat(queries.get(0).getText(),
equalTo("is:pr user:alice org:acme org:friends " //$NON-NLS-1$
+ "repo:bob/tool is:open")); //$NON-NLS-1$
assertThat(queries.get(0).getScopes(),
contains("user:alice", "org:acme", "org:friends", //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
"repo:bob/tool")); //$NON-NLS-1$
}

@Test
public void testAccessibleSearchAppliesAuthorFilterOnlyWhenSet() {
List<String> allAuthors = GitHubSearchQueries
List<Query> allAuthors = GitHubSearchQueries
.accessiblePullRequestQueries("alice", null, null, //$NON-NLS-1$
"OPEN", null); //$NON-NLS-1$
List<String> oneAuthor = GitHubSearchQueries
List<Query> oneAuthor = GitHubSearchQueries
.accessiblePullRequestQueries("alice", null, null, //$NON-NLS-1$
"OPEN", "carol"); //$NON-NLS-1$ //$NON-NLS-2$

assertThat(allAuthors, contains("is:pr user:alice is:open")); //$NON-NLS-1$
assertThat(allAuthors.get(0), not(containsString("author:"))); //$NON-NLS-1$
assertThat(oneAuthor,
contains("is:pr user:alice author:carol is:open")); //$NON-NLS-1$
assertThat(allAuthors.get(0).getText(),
equalTo("is:pr user:alice is:open")); //$NON-NLS-1$
assertThat(allAuthors.get(0).getText(),
not(containsString("author:"))); //$NON-NLS-1$
assertThat(oneAuthor.get(0).getText(),
equalTo("is:pr user:alice author:carol is:open")); //$NON-NLS-1$
}

@Test
Expand All @@ -86,16 +92,37 @@ public void testAccessibleSearchMapsMergedAndAllStates() {
@Test
public void testParsePullRequestPathsFromSearch() {
String json = "{\"total_count\":2,\"items\":[" //$NON-NLS-1$
+ "{\"pull_request\":{\"url\":\"https://api.github.com/repos/alice/one/pulls/7\"}}," //$NON-NLS-1$
+ "{\"pull_request\":{\"url\":\"https://api.github.com/repos/acme/two/pulls/12\"}}" //$NON-NLS-1$
+ "{\"updated_at\":\"2026-09-02T10:00:00Z\",\"pull_request\":" //$NON-NLS-1$
+ "{\"url\":\"https://api.github.com/repos/alice/one/pulls/7\"}}," //$NON-NLS-1$
+ "{\"updated_at\":\"2026-09-01T10:00:00Z\",\"pull_request\":" //$NON-NLS-1$
+ "{\"url\":\"https://api.github.com/repos/acme/two/pulls/12\"}}" //$NON-NLS-1$
+ "]}"; //$NON-NLS-1$

List<String> paths = GitHubJsonParser
.parseSearchPullRequestPaths(json);
List<GitHubSearchHit> hits = GitHubJsonParser.parseSearchHits(json);

assertThat(paths, hasSize(2));
assertThat(paths.get(0), equalTo("/repos/alice/one/pulls/7")); //$NON-NLS-1$
assertThat(paths.get(1), equalTo("/repos/acme/two/pulls/12")); //$NON-NLS-1$
assertThat(hits, hasSize(2));
assertThat(hits.get(0).path(),
equalTo("/repos/alice/one/pulls/7")); //$NON-NLS-1$
assertThat(hits.get(1).path(),
equalTo("/repos/acme/two/pulls/12")); //$NON-NLS-1$
assertThat(hits.get(0).updated(), notNullValue());
assertThat(hits.get(0).updated()
.after(hits.get(1).updated()), equalTo(true));
}

@Test
public void testSearchResultsThatAreNotPullRequestsAreIgnored() {
String json = "{\"total_count\":2,\"items\":[" //$NON-NLS-1$
+ "{\"number\":3,\"title\":\"a plain issue\"}," //$NON-NLS-1$
+ "{\"updated_at\":\"2026-09-01T10:00:00Z\",\"pull_request\":" //$NON-NLS-1$
+ "{\"url\":\"https://api.github.com/repos/acme/two/pulls/12\"}}" //$NON-NLS-1$
+ "]}"; //$NON-NLS-1$

List<GitHubSearchHit> hits = GitHubJsonParser.parseSearchHits(json);

assertThat(hits, hasSize(1));
assertThat(hits.get(0).path(),
equalTo("/repos/acme/two/pulls/12")); //$NON-NLS-1$
}

@Test
Expand Down
Loading