Repository navigation
v2.2.0b1 feat: add build123d FTC conversion and validation - #37
Merged
Merged
Conversation
Add signed offsets, affine transforms, draft, tapered and limited extrusions, and multi-section sweeps with strict graph replay. Support closed and periodic sketch B-splines and accurate rational-surface volume integration.
Capture Builder and algebra programs into portable feature traces, emit native FTC sources, and validate geometry in isolated processes. Include the API inventory, six real trace fixtures, inferred constraint recovery, and the 50-model benchmark. All models build; the tea-cup STEP reference-kernel failure remains explicit.
… expectations - Gordon patches sewn into a cube: the knot-span integral gives the exact 512000 mm3; the old 512019.2 was the fixed-order integrator's overshoot. - Silent-garbage fillet: the degenerate solid now measures 0 instead of a phantom 1036; the exit check still raises BlendVolumeViolation, so accept both messages. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an execution-based build123d → FTC pipeline: isolated tracing, exact profile reconstruction, native feature/boolean replay, generated Python modules and assemblies, API profiling, and independent geometry/STEP acceptance.
Verification
git diff --checkclean.CAD impact and known limits
Acceptance uses the actual returned Solid/Part/Assembly in world coordinates and checks declared BODIES consistency, validity, volume, surface area, solid count, absolute bounds and optional two-way STEP differences. Geometry thresholds were not relaxed.
This is sampled converter coverage. Remaining failures include the actual 625-hole model, holed-pipe/assembly consistency, selection failures, geometric mismatches, unsupported freeform constructions and a capture timeout. Non-full torus tube sections are explicitly rejected. Full topology history is partial for the new set/deformation operations; geometric inputs, output slots and graph replay are retained.
A full repository run also found three failures reproduced in an unchanged pre-review checkout (
6a63494) (blend diagnostics, FreeCAD articulated-subassembly joint count, and the Gordon-surface volume assertion). These were left unchanged at the user's request.Documentation
The converter README, API research/coverage inventory, benchmark notes, and regression fixtures are included. Benchmark notes describe the initial corpus run; the follow-up evidence above is reported separately.
Delivery scope
This PR preserves the current checkout and commit history. The new fix commit is
3c15754; it changes 23 files. No further feature edits or release-version bump were made during submission.The target GitHub
devis2f81fcd; this branch contributes three converter-related commits from their shared development baseline. The target merge was checked withgit merge-tree --write-treeand has no conflicts. The tests above ran on feature HEAD3c15754; CI should verify the combined development state.