Repository navigation
feat(editor): create a notebook from the workspace tab - #41
Merged
Merged
Conversation
A 'new' action in the notebooks header: a name (checked against the template's rule and the existing files), part or assembly (assembly starts with the first two parts of the workspace), create. An empty workspace opens on the workspace tab with the form shown. Server errors (a taken name) are shown in the form. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The completion entry (#40) had landed in the 2.2.1 section; both entries are under Unreleased now, with the editor-configuration fix. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The editor could not create a notebook: the "new" button was removed from the header earlier, and the backend endpoint (
POST /api/workspace/new, which writes the SDK's template) had no caller.sca editon an empty directory started and showed nothing.What
bracket.py already exists.); the server's reason is shown if it refuses.with app.setup: import simplecadapi as scad(hidden in the editor), a params cell, one feature, the product.Checked (real editor, browser)
Empty directory: form shown;
9bad namerefused;bracket(part) created and opened, tab switched to the notebook;rig(assembly) created, list showsrig ASSEMBLY uses bracket; creatingbracketagain is refused inline.npm run buildpasses; the template and creation logic were already covered bytest_editor.py.Not in this PR
sca new <name> [DIR]on the command line (creating the workspace directory and a first notebook without opening the editor).