Repository navigation
feat(zones): PPT-2649 search every zone the user can reach - #449
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfiltered zone listings and searches now return the zones a non-support user can reach through signage or support Read groups. Users with no reach still get 403. Existing tags, parent and support listings keep their behaviour.
Adds
descendants=truetogroup_idqueries, expanding anchors in SQL and excluding denied subtrees. Regenerates OpenAPI.Validation: focused zone specs, 55 examples with no failures. Crystal formatting passes. Ameba has the same 212 findings as the unchanged base, with no new findings.
Open question for Steve
With a group selected, Signage Manager needs to search inside that group's zones, not only its anchors. I added an explicit
descendants=trueoption to thegroup_idfilter for that, so existing callers are unaffected. If you would rathergroup_idwithqsimply searched the whole subtree, that is a small change. Callers who are not support and pass no filter now get the zones they can reach through signage or support groups, where they used to get a 403.