Repository navigation
fix(workplace): keep the colleague or room when a new home shortcut opens the meeting form - #571
Merged
Merged
Conversation
…ome page opens the meeting form "Meeting with a colleague", "meeting with the selected colleagues" and "book a favourite room" of the new home page filled the meeting form on a 300 ms timer. When the form page loaded shortly after the timer, `loadForm` replaced the model before the form was saved, and the colleague or room was lost. 14d9a5a fixed this for the replaced home page only. The new home page is the default since #561 and still had the timers. The three shortcuts now use `EventFormService.newFormWith()`, which saves the values with the form at once.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
MrYuion
added a commit
that referenced
this pull request
Oct 14, 2026
home-meeting-with failed 2 of 3 tries in CI run 38490657250 with an empty attendee list. The shortcut of the new home page writes the colleague to the meeting form on a 300 ms timer, and a form page that loads shortly after the timer drops it. #571 has the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three shortcuts of the new home page open the meeting form with a value already set:
Each one navigated, then wrote the value to the form on a 300 ms timer. When the form page loaded shortly after the timer,
loadFormreplaced the model before the form was saved, and the colleague or room was lost. The form looked normal, so the user could send a meeting that the colleague never hears about.#567 fixed this with
EventFormService.newFormWith(), but only in the replaced home page. The new home page is the default since #561 and still had the timers.The e2e suite found it:
home-meeting-with.spec.tsfailed 2 of 3 tries in CI run 38490657250 with an empty attendee list.Change
The three shortcuts call
newFormWith()before they navigate. It saves the value with the form at once, so the form page restores it at any load time. No timer remains in these shortcuts.Check
I opened the "meeting with" shortcut in mock mode with the scripts of the page slowed down, and read the attendees that the form held.
Three unit tests cover the shortcuts. They fail on the code before this change.
nx build workplacepasses.Not in this PR
"Book desks with the selected colleagues" has the same shape: it sets the group members of the desk form on a 300 ms timer, and the desk flow makes a new form when it loads. I did not measure it, and
BookingFormServicehas no helper likenewFormWith, so it needs its own change.Made by Claude Opus 5.5 in the Claude Code harness.
🤖 Generated with Claude Code