Skip to content

fix(workplace): keep the colleague or room when a new home shortcut opens the meeting form - #571

Merged
MrYuion merged 1 commit into
developfrom
fix/new-home-shortcut-prefill
Oct 14, 2026
Merged

MrYuion merged 1 commit into
developfrom
fix/new-home-shortcut-prefill

Conversation

@MrYuion

@MrYuion MrYuion commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Problem

Three shortcuts of the new home page open the meeting form with a value already set:

  • "meeting with" a colleague
  • "meeting with" the selected colleagues
  • Book on a favourite room

Each one navigated, then wrote the value to the form on a 300 ms timer. When the form page loaded shortly after the timer, loadForm replaced the model before the form was saved, and the colleague or room was lost. The form looked normal, so the user could send a meeting that the colleague never hears about.

#567 fixed this with EventFormService.newFormWith(), but only in the replaced home page. The new home page is the default since #561 and still had the timers.

The e2e suite found it: home-meeting-with.spec.ts failed 2 of 3 tries in CI run 38490657250 with an empty attendee list.

Change

The three shortcuts call newFormWith() before they navigate. It saves the value with the form at once, so the form page restores it at any load time. No timer remains in these shortcuts.

Check

I opened the "meeting with" shortcut in mock mode with the scripts of the page slowed down, and read the attendees that the form held.

Delay of each script Before After
60 ms colleague kept colleague kept
90 ms colleague kept colleague kept
120 ms colleague lost colleague kept
150 ms colleague lost colleague kept
180 ms colleague lost colleague kept
1000 ms colleague kept colleague kept

Three unit tests cover the shortcuts. They fail on the code before this change. nx build workplace passes.

Not in this PR

"Book desks with the selected colleagues" has the same shape: it sets the group members of the desk form on a 300 ms timer, and the desk flow makes a new form when it loads. I did not measure it, and BookingFormService has no helper like newFormWith, so it needs its own change.

Made by Claude Opus 5.5 in the Claude Code harness.

🤖 Generated with Claude Code

…ome page opens the meeting form

"Meeting with a colleague", "meeting with the selected colleagues" and
"book a favourite room" of the new home page filled the meeting form on a
300 ms timer. When the form page loaded shortly after the timer, `loadForm`
replaced the model before the form was saved, and the colleague or room
was lost.

14d9a5a fixed this for the replaced home page only. The new home page
is the default since #561 and still had the timers. The three shortcuts
now use `EventFormService.newFormWith()`, which saves the values with the
form at once.
@vercel

vercel Bot commented Oct 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
frontend-templates Ignored Ignored Oct 14, 2026 1:04am UTC

MrYuion added a commit that referenced this pull request Oct 14, 2026
home-meeting-with failed 2 of 3 tries in CI run 38490657250 with an empty
attendee list. The shortcut of the new home page writes the colleague to
the meeting form on a 300 ms timer, and a form page that loads shortly
after the timer drops it. #571 has the fix.
@MrYuion
MrYuion merged commit e4f9323 into develop Oct 14, 2026
9 checks passed
@MrYuion
MrYuion deleted the fix/new-home-shortcut-prefill branch October 14, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant