Skip to content

fix(auth): reject Entra guest accounts - #44

Merged
lorenzocorallo merged 2 commits into
mainfrom
fix/entra-reject-guests
Oct 12, 2026
Merged

lorenzocorallo merged 2 commits into
mainfrom
fix/entra-reject-guests

Conversation

@lorenzocorallo

Copy link
Copy Markdown
Member

Summary

  • Reject Entra sign-ins unless the ID token includes acct: 0, excluding B2B guest accounts and tokens without the claim.
  • Document the required Entra app registration claim and deployment impact.
  • Add policy tests for member, guest, malformed, and missing acct values.

Testing

  • Not run (no test execution information provided).

- Require the `acct: 0` member claim; reject guests and tokens without it
- Document the Entra app registration claim requirement
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 905ac9d9-efd1-4782-83c3-9b1dd223dc39

📥 Commits

Reviewing files that changed from the base of the PR and between 03f44d5 and c4e63de.


📒 Files selected for processing (4)
  • README.md
  • src/auth/policy.test.ts
  • src/auth/policy.ts
  • src/auth/providers.ts

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo lorenzocorallo changed the title Reject Entra guest accounts fix(auth): reject Entra guest accounts Oct 12, 2026
@lorenzocorallo
lorenzocorallo merged commit 80ae740 into main Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant