Repository navigation
fix(ui): Popups follow open/close animation - #1151
Tektonikal wants to merge 1 commit into
Conversation
|
Will close #766 |
|
|
||
| val scale: Float get() = hiddenScale + (1f - hiddenScale) * alpha | ||
| } | ||
|
|
There was a problem hiding this comment.
scale derived from alpha: alpha includes alphaMultiplier (= dragAlpha in OneConfigInterface.kt:175). Shell itself scales from progress only. HUD drag at opacity 0.3 → popup shrinks to 0.93 while shell stays 1.0. Fix: pass progress and alpha as separate providers, scale from progress.
| scaleY = shellScale | ||
| this.transformOrigin = TransformOrigin.Center | ||
| } | ||
| } |
There was a problem hiding this comment.
pivot mismatch: shell scales about shell centre, popup scales about own centre (dropdowns: about anchor edge). Popup shrinks in place while its anchor slides toward screen centre → gap up to 10% of distance from centre. Probably the “weird right-click menu” in PR description and the //TODO: fix this always moving right at Options.kt:181 — unverified. Fix: pivot = shell centre in popup-local coords (ShellState.shellBounds.center already exists; popup position from onGloballyPositioned).
3 participants
Description
Add a ShellTransition modifier that allows popups to follow along with the main screen scale and opacity animations. Has weird behaviour with the right-click menu for config options though.
Checklist