Skip to content

feat: access policies openapi spec - #164

Merged
sk-portkey merged 2 commits into
masterfrom
feat/access_policies_openapi
Oct 13, 2026
Merged

sk-portkey merged 2 commits into
masterfrom
feat/access_policies_openapi

Conversation

@sk-portkey

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 13:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The specification has conflicting error documentation and incorrectly models valid filter and subject inputs.

3 open findings
What changed in this PR

Adds OpenAPI coverage for managing workspace access policies.

Changes:

  • Adds CRUD endpoints, filtering, examples, and response definitions.
  • Defines access-policy subjects, targets, and request/response schemas.
  • Adds documentation navigation and tagging.
File Description
openapi.yaml Defines and documents the Access Policies API.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread openapi.yaml Outdated
Comment thread openapi.yaml Outdated
Comment thread openapi.yaml
sivadurga-d
sivadurga-d previously approved these changes Oct 13, 2026
Copilot AI balanced review requested due to automatic review settings October 13, 2026 14:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The schema permits an invalid subject combination and exposes misleading effect-dependent field names.

1 open finding
2 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Use effect-neutral names for all-user and all-agent fields

openapi.yaml:40996

These names conflict with the deny effect: when effect: deny, allow_all_users: true actually means the policy denies every user (and likewise for agents). Use effect-neutral response fields such as applies_to_all_users and applies_to_all_agents so consumers do not invert the policy's meaning.

🧠 Review effort: Balanced

@sk-portkey
sk-portkey force-pushed the feat/access_policies_openapi branch from f047cef to 700ece6 Compare October 13, 2026 14:43
@sk-portkey
sk-portkey merged commit a27feb9 into master Oct 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants