Cover test-build ordering, build-results, and test/install ON_ERROR_STOP - #79
Merged
jnasbyupgrade merged 1 commit intoSep 8, 2026
Conversation
…TOP [4916368] Template's test/install file now sets ON_ERROR_STOP and stops committing its self-overwriting .out file, per pgxntool's new check-test-install-error-stop check. Add test coverage for the new installcheck:test-build ordering edge, make build-results, and check-test-install-error-stop (script-level and Makefile-wiring). Covers pgxntool issues Postgres-Extensions/pgxntool#108 and Postgres-Extensions/pgxntool#97 (fixed by the paired pgxntool commit above, not by this one). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
2 tasks done
jnasbyupgrade
added a commit
to jnasbyupgrade/pgxntool-test
that referenced
this pull request
Sep 8, 2026
…dry-run behavior, drop a second uninstall Document that install's dry-run visibility comes from having no on-disk file named "install" rather than a .PHONY declaration (checked pgxs.mk and base.mk -- neither marks it phony), per reviewer request to verify rather than assume. Merge the FS_INSTALL=no negative-case check into the existing issue Postgres-Extensions#79 uninstalled-tree test so both share a single uninstall instead of each test uninstalling separately. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Sep 15, 2026
jnasbyupgrade
added a commit
to jnasbyupgrade/pgxntool-test
that referenced
this pull request
Sep 23, 2026
The addition case (pgxntool-test's new tests reference not-yet-existing pgxntool behavior) has one safe order: pgxntool merges first, per Postgres-Extensions#79/#109. Removal/rename is different: both orders leave one master's tests broken against the other's, since there's no version of the behavior both sides agree on simultaneously. Postgres-Extensions#93/Postgres-Extensions#72 (a variable rename) landed ~2 hours apart with no unrelated PR caught in the gap, but the rename still broke #95's own in-flight code via a plain merge from master (fixed in 42e0903) -- confirming a rename has no free lunch even when landed close together. #123/Postgres-Extensions#88 (open, unmerged) is a live example of this same unresolved case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jnasbyupgrade
added a commit
that referenced
this pull request
Oct 4, 2026
…STALL (#70) - Adds BATS coverage for pgxntool PR Postgres-Extensions/pgxntool#91, which adds `PGXNTOOL_ENABLE_FS_INSTALL` (gates `install` out of `test`/`verify-results`/`installcheck`/`test-build`, for existing-mode/pg_tle-style testing -- issues #55, #90) and `PGXNTOOL_ENABLE_PGXN_INSTALL` (independently gates pgtap's own `pgxn install --sudo` auto-install, defaulting to follow `PGXNTOOL_ENABLE_FS_INSTALL`). - Extends `test/standard/make-test.bats`: default/override/independent-override behavior, structural proof via `make -p -n` that `install`/`pgtap` prerequisites are genuinely removed, a dry-run proof (fake `DESTDIR`) that the `pgxn install pgtap --sudo` recipe disappears when disabled, and end-to-end proof that `make test PGXNTOOL_ENABLE_FS_INSTALL=no` succeeds against an already-installed tree but fails against a genuinely uninstalled one. - Also tightens two `installcheck` prerequisite-list assertions (the pre-existing issue #79 one and the new one) to match the exact `install` token instead of a `grep -w` substring, which false-matched inside the unrelated `test/install/schedule` path. - Merged `master` in to pick up issue #79's test-build-ordering/build-results/ON_ERROR_STOP coverage (which depended on pgxntool#109, since merged) -- one real conflict in `test/standard/make-test.bats` where both branches added independent test sections at the same point, resolved by keeping both.
jnasbyupgrade
added a commit
that referenced
this pull request
Oct 4, 2026
Paired with Postgres-Extensions/pgxntool#123, which renames pgxntool's `build-results` target to `results-build` (review feedback on #109: the old name was too close to the existing `results` target). Updates the `make build-results` call sites this repo's own tests added in #79 (`test/standard/make-test.bats`) to `results-build`, so the suite keeps exercising the renamed target instead of a now-nonexistent one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#109
Template's
test/installfile now setsON_ERROR_STOPand stops committing its self-overwriting.outfile, per pgxntool's newcheck-test-install-error-stopcheck.Test coverage added:
installcheck:test-buildordering edge, viamake -ndry-run (issue #108)make build-results: refreshes clean files, skips and reports files whose actual output containsERROR:, and still exits non-zero on a partial skipcheck-test-install-error-stop: script-level decision logic (directON_ERROR_STOP, viapsql.sql, missing) and Makefile wiring (recipe args, disable viaPGXNTOOL_ENABLE_TEST_INSTALL_ERROR_STOP_CHECK, exit-status propagation)Covers pgxntool issues #108 and #97 (fixed by the paired pgxntool PR above, not by this one).