Add test coverage for the test/install ON_ERROR_STOP rule - #86
Open
jnasbyupgrade wants to merge 3 commits into
Open
jnasbyupgrade wants to merge 3 commits into
jnasbyupgrade wants to merge 3 commits into
Conversation
Add tests/updates for pgxntool commit Postgres-Extensions/pgxntool#122 (order-sensitive ON_ERROR_STOP detection in check-test-install-error-stop.sh): - Bare substring grep passed a file that only ever turned ON_ERROR_STOP off; the script now requires an explicit on-value seen in file order. Extend the existing script-logic bats file with the two new cases that distinguish this from the old bare-substring behavior: - on-then-off still passes (a later off doesn't undo an earlier on) - off-only (never explicitly on) fails Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add tests/updates for pgxntool commit ff766b3 (Postgres-Extensions/pgxntool#122): an explicit `\set ON_ERROR_STOP on` excuses a later turn-off, but including psql.sql does not. - psql.sql plus `\set ON_ERROR_STOP off` fails - psql.sql plus `\unset ON_ERROR_STOP` fails Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jnasbyupgrade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired with Postgres-Extensions/pgxntool#122, which changes
check-test-install-error-stop.shto this rule: atest/install/*.sqlfile passes iff it explicitly enablesON_ERROR_STOP(any later disable is then fine), or includestest/pgxntool/psql.sqland never disables it (\set ON_ERROR_STOP offor\unset ON_ERROR_STOP).test/standard/check-test-install-error-stop-script.batscovers each branch of the rule:psql.sqlonly: passespsql.sqlplus\set ON_ERROR_STOP off: failspsql.sqlplus\unset ON_ERROR_STOP: failsTest plan
test/standard/check-test-install-error-stop-script.bats: 10/10 passed (8 existing + 2 new).test-full-20261004T152700.log).🤖 Generated with Claude Code