The coordinator names its siblings by full path at its own tag; a script cuts the tag and a check refuses skew - #48
Merged
Merged
Conversation
…ipt cuts the tag and a check refuses skew publishing-v10 called the four siblings by ./ path, which resolves against the consumer's repository, so pydevices v0.5.0's publish run died at startup with zero jobs (#47). The refs are literal again, at @publishing-v11; scripts/cut_publishing_tag.sh is the only way a tag is cut (it rewrites the refs in the commit it tags), and checks.yml's sibling-refs job refuses any ./ call in a reusable and any coordinator whose sibling refs name more than one tag. Closes #47, reopens the intent of #26 the way that works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47.
publishing-v10's./sibling refs resolve against the consumer's repository, so pydevices v0.5.0's publish run died at startup (twice, zero jobs). This puts the four refs back to full path at a literal tag —@publishing-v11— and makes skew impossible by procedure rather than hope:scripts/cut_publishing_tag.sh Nis the only way a tag is cut (it rewrites the refs and tags the same commit), and the newsibling-refscheck fails any reusable that uses./and any coordinator whose sibling refs name more than one tag. The runbook says never to pin v10. The real cross-repo gate #47 asks for is the pydevices v0.5.0 retry on v11, which follows this merge.