The tools-ref defaults follow the tag too - #49
Merged
Merged
Conversation
reusable-build-pydevices-distributions, reusable-synchronize-mip-package and reusable-validate-pyscript-filesystem-toml check this repository's scripts/ out at a publishing-tools-ref whose default was still publishing-v6, so the v11 coordinator ran v6's build tools (identical today; found by the 0.5.0 verification). cut_publishing_tag.sh now rewrites those defaults with the sibling refs, and the sibling-refs check covers every ref literal in the reusables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the pydevices 0.5.0 verification: three reusables carry
publishing-tools-refinput defaults still atpublishing-v6, and the v11 coordinator does not override them, so a v11 run checksscripts/out at v6 — the same 'a tag does not contain the tools it runs' class, one level down. Harmless today (the scripts are identical between v6 and v11, the shipped wheels prove it). This sets the defaults to v11, makescut_publishing_tag.shrewrite them with the sibling refs, and widens thesibling-refscheck to every ref literal inreusable-*.yml. No new tag is cut for it; v12, when something real changes, will be the first tag cut with full coverage.