Repository navigation
Fix heating mode keyerror - #166
Conversation
Replace try/except KeyError blocks in heating/hotwater get_mode with early returns when state.mode is missing. Add _keep_missing_state to PollingMixin that carries over dropped state keys from the previous poll for up to MAX_STALE_STATE_POLLS (5) consecutive incomplete responses, logging a warning per poll listing affected products and missing keys, plus a debug log showing the keys that did arrive. After the threshold, accept
Keys Hive may legitimately omit (boost, the colour keys) were kept from the previous poll for up to five polls, which could report stale state such as boost ON. Carry over only mode, name, status and target, and drop the per-product count for products that leave the response. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add `run-file`, `run-live`, `simulate-file`, `simulate-live` targets that start background polling sessions (fixture or real account) and write to logs/. Add `logs` (tail -F), `status` (list runners), `stop` (kill runners), and `live-forget` (clear keychain credentials). Ignore logs/ in .gitignore.
…/Pyhiveapi into fix-heating-mode-keyerror
Add `make call` target and `--call` flag that send commands to a running session over a Unix socket. Commands include poll, mode/state inspection, drop control, debug/interval adjustment, and device control (set-mode, set-temp, boost, turn-on/off). Device control requires `--allow-writes` flag at session start. Add `make help` target documenting all targets and options. Refactor Makefile to use RUN_FLAGS for shared options and add detailed
🤖 Claude Code ReviewNo blocking bugs found. Bugs: none confirmed. Should fix / questions
Minor
Home Assistant check: I fetched Not reviewed in depth: the Makefile and the runner's Keychain and socket handling. This is a dev-only tool, and I only skimmed those parts. Automated review by Claude Code · workflow run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #166 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 30 30
Lines 2576 2599 +23
Branches 297 306 +9
=======================================
+ Hits 2575 2598 +23
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
No description provided.