Conversation
The GitHub Actions Pages deploy that publish-gh-pages uses ignores a CNAME file, so the input never set the custom domain: Settings → Pages does, and it already holds python-programming.quantecon.org. From QuantEcon/actions v0.12.0 the action warns on every deploy that still passes it (QuantEcon/actions#109, QuantEcon/actions#110). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a straightforward removal of an ineffective action input with clarifying documentation and no functional impact on deployment.
Review effort: Lite
Findings: None
What changed in this PR
Removes the unused cname input from the GitHub Actions Pages publish workflow since the Pages custom domain is configured in repository Settings (and the action’s CNAME file output is ignored for workflow-based Pages deploys), avoiding new warnings introduced by quantecon/actions v0.12.0.
Changes:
- Drop
cname: python-programming.quantecon.orgfrom thepublish-gh-pagesaction invocation. - Add an inline comment documenting where the custom domain is configured and why the workflow does not manage it.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Removes the no-op cname input and documents that the domain is set via Settings → Pages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish-gh-pagesdeploys through GitHub Actions Pages, which ignores aCNAMEfile, so thecname:input has never set the custom domain. Settings → Pages does, and it holdspython-programming.quantecon.org(checked withgh api repos/QuantEcon/lecture-python-programming/pages:cname: python-programming.quantecon.org,build_type: workflow,https_enforced: true). From QuantEcon/actions v0.12.0 the action warns on every deploy that still passes the input. This removes it and leaves a comment saying where the domain lives.No effect on the published site. The only other thing the input did was write a
CNAMEfile into the build directory, so the release HTML archive stops carrying one; nothing reads it when serving.This workflow runs on a
publish*tag, so this PR's CI does not exercise it. The check is the next real publish after merge: once Dependabot moves this repo from@v0.11.1to v0.12.0, publish runs would otherwise start showing thecnamewarning; with this change they won't, and the site should still serve onpython-programming.quantecon.org.Follow-up from QuantEcon/actions#110.
Assisted-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code