Conversation
- functions.md: "Rewrite the function `factorial()` in from [Exercise 1]" -> "... `factorial()` from [Exercise 1]" - python_by_example.md hint: "noted that suppose `var = 42`" -> "note that if `var = 42`" Spotted by Copilot on QuantEcon/lecture-python-programming.ml#14, which copies exercise blocks byte-for-byte from this repo, so the typos can only be corrected here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are limited to verified typo fixes in exercise text and do not affect MyST structure or code behavior.
Review effort: Lite
Findings: None
What changed in this PR
This PR fixes two minor wording typos inside MyST exercise/hint blocks in the lecture notes, improving clarity without changing any executable code or exercise structure.
Changes:
- Fixes grammar in
functions.mdExercise 5 (“in from” → “from”). - Fixes wording in
python_by_example.mdExercise 2 hint (“noted that suppose” → “note that if”).
| File | Description |
|---|---|
| lectures/functions.md | Corrects a typo in Exercise 5 instructions for the recursive factorial() rewrite. |
| lectures/python_by_example.md | Corrects a typo in Exercise 2 hint text about f-strings used in a plot legend. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small wording typos inside exercise blocks:
functions.md(Exercise 5)factorial()in from [Exercise 1] using recursion.factorial()from [Exercise 1] using recursion.python_by_example.md(Exercise 2 hint)var = 42, …var = 42, …Copilot spotted both on QuantEcon/lecture-python-programming.ml#14. That edition keeps exercise blocks byte-for-byte identical to this repo, so the typos can only be corrected at the source.
On merge: the translation sync will open a small PR in each of the zh-cn, fa and fr editions for these two lectures. The ml edition is not on the sync, so it will be brought into line separately.
🤖 Generated with Claude Code