Add unit tests / fix issues that spun up - #11
Merged
Merged
Conversation
When the key of the GET oder POST does not exist, an error gets printed as this undefined value gets used by the method when using get or post. However this is something that should explicitly NOT happen as the wrapper is designed to prevent that. As such a new test is being added and the bug is fixed.
Fix: Setup no longer trims passwords so credentials match exactly Fix: ShareController blocks direct dotfile access when hidden and refuses shares left outside the current browse root Fix: Logout regenerates the PHP session ID after logout
Fix: Some outside files could still be seen by the user even though they cannot be accessed.
The main issue with the configuration system was that errors were not really that visible. Now the configuration errors are resulting in an exception. Also tests were added to test if these things work correctly.
As the config system is now different the test does not work anymore.
QuickWrite
commented
Sep 29, 2026
Owner
Author
There was a problem hiding this comment.
Just the lock file by itself is adding a lot of lines...
If the user manages to get a file that has a \r\n inside of it (or something like that) the header would leak and a malicious header could be inserted. As such this is now checked (normally this should NEVER happen) as a sanity check inside of the Response object.
QuickWrite
marked this pull request as ready for review
September 29, 2026 23:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the application should be stable, unit tests are sensible.
Closes #5