chore: stop using gulp as a test task runner - #10415
Merged
Merged
Conversation
github-actions
Bot
added
PR: chore
lizschwab
marked this pull request as ready for review
September 9, 2026 19:04
gonfunko
reviewed
Sep 10, 2026
| * @param {string} command Command line to run. | ||
| * @return {Promise} Asynchronous result. | ||
| */ | ||
| export async function runTestCommand(id, command) { |
Contributor
There was a problem hiding this comment.
Is this used by anything?
Contributor
Author
There was a problem hiding this comment.
I was using it but removed it in favor of just running the tests that were using it directly in node. I'll remove it.
Contributor
There was a problem hiding this comment.
Now that this is just being run by node, do any of the methods or constants in it need to be exported?
Contributor
Author
There was a problem hiding this comment.
Good catch, I don't think they need to be exported.
gonfunko
reviewed
Sep 10, 2026
gonfunko
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10306
Proposed Changes
Removes the gulp test task file and uses nx instead to orchestrate which tests are run in which order. A couple of the test tasks live in the gulp build tasks file, which will be addressed with #10305, so those were not updated.
Reason for Changes
Using gulp for this was causing issues where nx was unable to cache test results and had to run blockly tests separately from other tests. These can now be run in parallel.