fix: Fix bug that could cause unneeded scrollbars to appear when deserializing workspace comments - #10424
Merged
Merged
Conversation
…rializing workspace comments
lizschwab
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10416
Proposed Changes
This PR fixes a bug that caused workspace comments that were serialized without a scrollbar to display one when deserialized. Previously, deserialization set the comment's text before its bounds. Therefore, if the comment's text was (a) too large to fit in a default-sized workspace comment and (b) wider than the comment's serialized bounds minus the size of the scroll gutters, deserialization would:
Inverting the order to set the bounds first and then the text when deserializing fixes this, because the text is narrow enough to fit without scrollbars as long as the scrollbar isn't already showing.
Reason for Changes
Serializing and deserializing a workspace should give identical results.