Repository navigation
Fall back to the rosdistro cache for snapshots without dependency metadata - #159
Merged
traversaro merged 2 commits intoOct 6, 2026
Merged
Conversation
…ependency metadata Snapshots written before vinca-snapshot recorded dependencies made every recipe generation fail with "regenerate the rosdistro snapshot". Fall back to the rosdistro cache, which is what vinca-snapshot uses to fill the field, and warn once, so existing snapshots keep working until they are regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
traversaro
approved these changes
Oct 6, 2026
Member
|
Thanks! |
Tobias-Fischer
added a commit
to Tobias-Fischer/ros-distro-template
that referenced
this pull request
Oct 6, 2026
RoboStack/vinca#159) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since snapshots started recording
dependencies, vinca raisesRuntimeError: Snapshot metadata for '<pkg>' has no dependencies; regenerate the rosdistro snapshotfor any snapshot written before then. That is the case for ros-rolling and ros-humble today. They can't move to vinca master without regenerating their snapshot, which also bumps hundreds of package versions and forces rebuilds.This PR makes that case a fallback instead of an error:
_get_direct_dependsresolves dependencies from the rosdistro cache through theDependencyWalker. That's the same sourcevinca-snapshotuses to fill the field.dependencies: unchanged.Testing
pytest vinca/: 251 passed.test_snapshot_without_dependencies_requires_regenerationis replaced by a test of the fallback.mainon Linux (linux-64), with its current snapshot andskip_existingremoved (to generate every recipe):system_modes/system_modes_msgs. Those are no longer in rolling's rosdistro, so the cache can't resolve them.🤖 Generated with Claude Code