Skip to content

Fall back to the rosdistro cache for snapshots without dependency metadata - #159

Merged
traversaro merged 2 commits into
RoboStack:masterfrom
Tobias-Fischer:fix/snapshot-deps-fallback
Oct 6, 2026
Merged

traversaro merged 2 commits into
RoboStack:masterfrom
Tobias-Fischer:fix/snapshot-deps-fallback

Conversation

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Since snapshots started recording dependencies, vinca raises RuntimeError: Snapshot metadata for '<pkg>' has no dependencies; regenerate the rosdistro snapshot for any snapshot written before then. That is the case for ros-rolling and ros-humble today. They can't move to vinca master without regenerating their snapshot, which also bumps hundreds of package versions and forces rebuilds.

This PR makes that case a fallback instead of an error:

  • Snapshots without dependency metadata: _get_direct_depends resolves dependencies from the rosdistro cache through the DependencyWalker. That's the same source vinca-snapshot uses to fill the field.
  • Warning: vinca prints a one-time warning saying the snapshot should be regenerated to pin its dependencies.
  • Snapshots with dependencies: unchanged.

Testing

🤖 Generated with Claude Code

Tobias-Fischer and others added 2 commits October 6, 2026 11:57
…ependency metadata

Snapshots written before vinca-snapshot recorded dependencies made every recipe
generation fail with "regenerate the rosdistro snapshot". Fall back to the
rosdistro cache, which is what vinca-snapshot uses to fill the field, and warn
once, so existing snapshots keep working until they are regenerated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@traversaro

Copy link
Copy Markdown
Member

Thanks!

@traversaro
traversaro merged commit 005b6e3 into RoboStack:master Oct 6, 2026
3 checks passed
Tobias-Fischer added a commit to Tobias-Fischer/ros-distro-template that referenced this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants