Repository navigation
Resolve ros_distro selectors in package tests - #164
Open
Tobias-Fischer wants to merge 5 commits into
Open
Tobias-Fischer wants to merge 5 commits into
Tobias-Fischer wants to merge 5 commits into
Conversation
Tobias-Fischer
force-pushed
the
feat/distro-test-selectors
branch
from
October 8, 2026 02:15
649fee9 to
46e8dd0
Compare
A configuration can extend another one (relative path). Package lists are combined, mutex_package is merged (run_constraints replaced per package), other keys of the extending file win. pkg_additional_info.yaml, dependencies.yaml, patches, tests and conda_index files of every layer are combined, each relative to its configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a-gha reads the layered configuration Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The recipe refers to patch/<file>; the template copies the patch from its configuration's patch directory. Before, a path relative to a common root was copied relative to the working directory, which broke for patches outside it (e.g. with extends). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Selectors that test ros_distro (e.g. if: ros_distro in ["humble", "jazzy"]) are resolved when a test file is put into a recipe, so one test file serves several distributions; platform selectors stay for rattler-build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
force-pushed
the
feat/distro-test-selectors
branch
from
October 10, 2026 04:26
46e8dd0 to
e5b291c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the
extendsPR (and #162). Its own change is the last commit.When a test file from
tests/is put into a recipe,if:selectors that testros_distroare resolved. One test file can then serve several distributions, which matters once they sharetests/throughextends. All other selectors (osx,win, …) are left unchanged for rattler-build.This replaces the Jinja templating with custom delimiters that RoboStack used to render distribution-specific tests. Its two such tests, converted to these selectors, produce identical recipes.
There's a new test for the resolution, all tests pass, ruff and pyrefly are clean, and the README has a short section.
🤖 Generated with Claude Code