fix(atomic): use system memory scope for SystemAtomic types - #400
Merged
Merged
Conversation
Contributor
Author
|
#386 should now take care of windows CI failures. |
LegNeato
force-pushed
the
fix-system-atomic-scope
branch
from
September 29, 2026 03:23
04a0691 to
56c02b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemAtomicF32andSystemAtomicF64previously used thedevicedomain scope instead of the intendedsystemscope in their macro instantiations. This mismatch caused.gpuscoped atomic PTX instructions to be emitted (atomic. global.gpu...) rather than.sysscoped instructions.This bug meant that any system-level synchronization (between the host CPU and GPU, or across multiple GPUs over PCIe/NVLink) would fail to observe proper cache coherency, silently causing data races and corrupted shared memory states. This PR corrects the macro arguments to use the correct
systemscope for system atomics.Closes #399
Changes
$scopeargument forSystemAtomicF32andSystemAtomicF64fromdevicetosystemincrates/cuda_std/src/atomic.rs.Testing
cargo buildpassescargo clippy --workspacepasses