new ASIO host implementation - #1331
LastExceed wants to merge 20 commits into
Conversation
|
The non-
|
9c95154 to
b6cc570
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Ah right, I had missed the |
This comment was marked as resolved.
This comment was marked as resolved.
|
I moved them to the platform dependencies for now to be consistent with what we currently have, but it might be worth revisiting this in the future as it could get rid of some duplicates. E.g. |
This comment was marked as resolved.
This comment was marked as resolved.
774c869 to
15346d6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Any issue with channel count not being const fn? And can’t as u64 be used here? (Regarding the two MSRV versions) |
|
I agree that there are definitely some places where rustfmt is in my opinion making code less readable, keeping a codebase (like cpal) legible and clear is important, but I think just being logical can exceed rustfmt in terms of neatness |
No, but I was hoping that we'd up the MSRV for
where do you mean exactly? |
This comment was marked as outdated.
This comment was marked as outdated.
6c43e14 to
39c88b2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ce9faef to
decdcf5
Compare
|
The branch is finally fully ready to be reviewed and merged. Implementing this was quite the journey, I kept running into edge cases that required me to change my approach over and over. I recognize that big PRs like this can be daunting to review, especially when everything is squashed everything into a single commit as I had initially done, so I spent the last 2 days rewriting the git history in order to make the PR as approachable as I can. Please let me know whether or not this turns out to be helpful. |
Closes #1299
Obsoletes #1083