feat: revisit beta annotations - #1045
Open
vladimir-a-sap wants to merge 19 commits into
Open
vladimir-a-sap wants to merge 19 commits into
vladimir-a-sap wants to merge 19 commits into
Conversation
vladimir-a-sap
commented
Sep 17, 2026
| * @param jackson The {@link ObjectMapper} to use | ||
| * @return the current instance of {@link ClientResponseHandler} with the changed object mapper | ||
| */ | ||
| @Beta |
Contributor
Author
There was a problem hiding this comment.
- last update was in august 2025
- it looks like an internal SDK class not supposed to be directly used by our users
vladimir-a-sap
commented
Sep 17, 2026
| * @since 1.15.0 | ||
| */ | ||
| @Beta | ||
| public class OrchestrationConfigClient extends OrchestrationConfigsApi { |
Contributor
Author
There was a problem hiding this comment.
- created in Jan 2026
- no method signature changes or field changes since creation
vladimir-a-sap
commented
Sep 17, 2026
Contributor
Author
There was a problem hiding this comment.
- removed
@betafrom standard java methods (equals, hashcode, etc.)
vladimir-a-sap
commented
Sep 17, 2026
Contributor
Author
There was a problem hiding this comment.
- removed
@betafrom standard java methods (equals, hashcode, etc.)
vladimir-a-sap
commented
Sep 17, 2026
Contributor
Author
There was a problem hiding this comment.
- removed
@betafrom standard java methods (equals, hashcode, etc.)
vladimir-a-sap
commented
Sep 17, 2026
| * @param apiVersion the API version to target. | ||
| * @return a new client. | ||
| */ | ||
| @Beta |
Contributor
Author
There was a problem hiding this comment.
- api introduced in december 2024
- signature never changed since then
… into revisit-beta-annotations
vladimir-a-sap
commented
Sep 17, 2026
Contributor
Author
There was a problem hiding this comment.
- internal sdk class (not supposed to be used directly, as it seems)
- was introduced in april 2026
- has never been changes since its introduction
vladimir-a-sap
commented
Sep 17, 2026
| * @return The completion response. | ||
| * @throws OrchestrationClientException If the request fails. | ||
| */ | ||
| @Beta |
Contributor
Author
There was a problem hiding this comment.
- implemented in november 2024
- no changes to method signature or meaningful changes to method behavior since then
vladimir-a-sap
commented
Sep 17, 2026
Contributor
Author
There was a problem hiding this comment.
- introduced in jan 2025
- package-private scope, intermal SDK usage only
- no meaningful changes since its introduction
… into revisit-beta-annotations
vladimir-a-sap
commented
Sep 17, 2026
| * | ||
| * @param resourceGroup the resource group of the deleted deployment, usually "default". | ||
| */ | ||
| @Beta |
Contributor
Author
There was a problem hiding this comment.
- introduced in december 2024
- no signature changes since then
vladimir-a-sap
commented
Sep 17, 2026
| */ | ||
| @Nonnull | ||
| @Beta | ||
| public ClientStreamingHandler<D, R, E> objectMapper(@Nonnull final ObjectMapper jackson) { |
Contributor
Author
There was a problem hiding this comment.
- no signature changes since aug 2025
- apparently not supposed to be used by users directly, rather inside SDK
vladimir-a-sap
commented
Sep 17, 2026
vladimir-a-sap
left a comment
vladimir-a-sap
left a comment
Contributor
Author
There was a problem hiding this comment.
added clarifications on proposed changes
vladimir-a-sap
commented
Sep 17, 2026
| */ | ||
| @Slf4j | ||
| @RequiredArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @Beta |
Contributor
Author
There was a problem hiding this comment.
- while the class itself seems to be stable enough, there are still multiple method-level
@betaannotations where API still doesn't look stable enough
vladimir-a-sap
marked this pull request as ready for review
September 17, 2026 13:00
vladimir-a-sap
changed the title
… into revisit-beta-annotations
# Conflicts: # core-services/prompt-registry/src/main/java/com/sap/ai/sdk/prompt/registry/OrchestrationConfigMixin.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
https://github.com/SAP/ai-sdk-java-backlog/issues/432
related documentation task: https://github.com/SAP/ai-sdk-java-backlog/issues/438
Definition of Done
Aligned changes with the JavaScript SDK(not applicable, java code only)Release notes updated(seems to be irrelevant for this particular task, documentation will be updated instead)