Fix missing model name in console error output for driver failures) - #6066
Open
sakshipatil-hue wants to merge 1 commit into
Open
sakshipatil-hue wants to merge 1 commit into
sakshipatil-hue wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where low-level driver or engine errors (such as casting exceptions) fail to display the failing model or snapshot name in the console error output.
Updated
_format_node_errorinsqlmesh/core/console.pyto add robust fallback checks. Iferror.nodelacks standardsnapshot_nameorSnapshotIdattributes, it now checks for a.nameattribute or safely falls back to stringifying the node (str(error.node)), ensuring the failing model name is always surfaced in logs.Test Plan
Manually verified that when a node execution fails due to low-level engine or driver errors where
error.nodelacks standard snapshot attributes, the console correctly falls back to.nameorstr(error.node)and successfully outputs the failing model name instead of leaving it blank.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO