Skip to content

fix(vscode): scope render tab assertions to the editor tab #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tripleaceme wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix(vscode): scope render tab assertions to the editor tab #6076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions vscode/extension/tests/render.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ test('Render works correctly', async ({ page, sharedCodeServer, tempDir }) => {

// Check if the model is rendered by check if "`oi`.`order_id` AS `order_id`," is in the window
await expect(page.locator('text="marketing"."customer_id" AS')).toBeVisible()
await expect(page.locator('text=sushi.customers (rendered)')).toBeVisible()
await expect(page.getByRole('tab', { name: 'sushi.customers (rendered)' })).toBeVisible()
})

test('Render works correctly with model without a description', async ({
Expand Down Expand Up @@ -74,7 +74,7 @@ test('Render works correctly with model without a description', async ({

// Check if the model is rendered correctly
await expect(page.locator('text="orders"."id" AS "id",')).toBeVisible()
await expect(page.locator('text=sushi.latest_order (rendered)')).toBeVisible()
await expect(page.getByRole('tab', { name: 'sushi.latest_order (rendered)' })).toBeVisible()
})

test('Render works correctly with every rendered model opening a new tab', async ({
Expand Down Expand Up @@ -104,7 +104,7 @@ test('Render works correctly with every rendered model opening a new tab', async
await runCommand(page, 'Render Model')

// Check if the model is rendered correctly
await expect(page.locator('text=sushi.latest_order (rendered)')).toBeVisible()
await expect(page.getByRole('tab', { name: 'sushi.latest_order (rendered)' })).toBeVisible()

// Open the customers model
await page
Expand All @@ -117,8 +117,8 @@ test('Render works correctly with every rendered model opening a new tab', async
await runCommand(page, 'Render Model')

// Assert both tabs exist
await expect(page.locator('text=sushi.latest_order (rendered)')).toBeVisible()
await expect(page.locator('text=sushi.customers (rendered)')).toBeVisible()
await expect(page.getByRole('tab', { name: 'sushi.latest_order (rendered)' })).toBeVisible()
await expect(page.getByRole('tab', { name: 'sushi.customers (rendered)' })).toBeVisible()
})

test('Render shows model picker when no active editor is open', async ({
Expand Down Expand Up @@ -146,7 +146,7 @@ test('Render shows model picker when no active editor is open', async ({
await page.locator('text=sushi.customers').click()

// Verify the rendered model is shown
await expect(page.locator('text=sushi.customers (rendered)')).toBeVisible({
await expect(page.getByRole('tab', { name: 'sushi.customers (rendered)' })).toBeVisible({
timeout: 2_000,
})
})