Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sqlmesh/core/model/definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -2361,7 +2361,15 @@ def load_sql_based_model(
**meta_fields,
)

kind = common_kwargs.pop("kind", ModelMeta.all_field_infos()["kind"].default)
kind = common_kwargs.pop("kind", None)
if kind is None:
# Use the project's default kind, if any, before falling back to the ModelMeta default
default_kind = rendered_defaults.get("kind")
kind = (
create_model_kind(default_kind, dialect, rendered_defaults)
if default_kind is not None
else ModelMeta.all_field_infos()["kind"].default
)

if kind.name != ModelKindName.SEED:
return create_sql_model(
Expand Down
27 changes: 27 additions & 0 deletions tests/core/test_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -7004,6 +7004,33 @@ def test_end_no_start():
load_sql_based_model(expressions, defaults={"start": "2023-01-01"})


def test_model_defaults_kind():
defaults = ModelDefaultsConfig(dialect="duckdb", kind="full").dict()

model = load_sql_based_model(
parse(
"""
MODEL (name db.table);
SELECT 1 AS a
"""
),
defaults=defaults,
)
assert model.kind.name == ModelKindName.FULL

# a kind set on the model itself still takes precedence
model = load_sql_based_model(
parse(
"""
MODEL (name db.table, kind VIEW);
SELECT 1 AS a
"""
),
defaults=defaults,
)
assert model.kind.name == ModelKindName.VIEW


def test_variables():
@macro()
def test_macro_var(evaluator) -> exp.Expr:
Expand Down