Skip to content

ci: dispatch PR validation manually; never queue on PR events - #1780

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
ci/manual-pr-dispatch
Sep 18, 2026
Merged

ScriptedAlchemy merged 1 commit into
masterfrom
ci/manual-pr-dispatch

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Why the prior two cuts still failed

GitHub creates/queues a workflow run before evaluating job-level conditions. #1744 made drafts skip all jobs; the run objects still queued. #1773 made ci-full the only triggering label; the automated PR swarm applied ci-full to every PR. At 10:00: 173 open PRs, 80 queued CI runs, beta.45 publish blocked. I cleared 81 runs manually; publish immediately started and shipped all 9 assets.

Only robust GitHub-native policy

No PR event trigger exists for expensive validation:

  • ci.yml: default-branch push + workflow_dispatch.
  • plugin-validation.yml, sdk-conformance.yml: path-filtered default-branch push + dispatch.
  • all three hotpath workflows: dispatch only.
  • only pr-run-cleanup (closed) and read-only release-PR integrity retain PR events.

Run a PR head explicitly:

gh workflow run ci.yml --ref <branch>
# optional additions:
gh workflow run ci.yml --ref <branch> -f run_os=true -f run_hosts=true -f run_perf=true

Opening, pushing, marking ready, and labels now create no run. A CI dispatch runs repository gates, harness self-tests, and Linux. Default-branch pushes run Linux only, so release matrix jobs retain runner slots. OS/host/perf are explicit.

More deletion

  • Removed dead pr-dogfood: without PR context it could never run.
  • debug-cli runs only with run_hosts=true, its only remaining consumers.
  • MCP conformance moved to stock-host lane on that shared binary.
  • Removed dead PR commit-range step (local hook and default-branch push range check remain).
  • Hotpath profile compares dispatched head with origin/master and records branch metadata rather than empty PR fields.

Net workflow diff: 65 additions, 272 deletions.

actionlint on all workflows, release safety, Rust cache-lineage guard pass. CONTRIBUTING.md updated.

GitHub queues a workflow run before evaluating job conditions, and the PR swarm applied every opt-in label: 80 runs again blocked beta publish after the label-only cut. Remove pull-request triggers entirely from CI, plugin/SDK validation, and hotpath workflows. Dispatch on the branch ref when wanted; CI runs Linux by default and explicit booleans add OS, hosts, or parity. Default-branch pushes run Linux only. Remove the now-dead PR dogfood job and run MCP conformance with the manually requested stock-host lane's shared CLI.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2214b44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 3653d0d into master Sep 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant