test(windows): release fixture handles before mutation - #1970
Merged
ScriptedAlchemy merged 2 commits intoSep 24, 2026
Merged
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ScriptedAlchemy
changed the title
ScriptedAlchemy
deleted the
codex/fix-windows-artifact-replacement-fixture
branch
September 24, 2026 04:16
ScriptedAlchemy
added a commit
that referenced
this pull request
Sep 24, 2026
* test(query): release artifact builder before replacement * test(lsp): let fake server release its project cwd (cherry picked from commit b664979)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Windows tests were failing before they exercised the behavior they asserted. The content-addressed reader test kept its finalized SQLite builder open while replacing the artifact, and the LSP missing-root test kept its fake server's process working directory inside the project it tried to delete. Windows refused those mutations while the fixture handles were still live.
Release the finalized builder before the reader checkpoint. Move the fake server's working directory to the test parent after launch, keeping the broker client warm while allowing the admitted root to disappear. Both focused tests pass locally (1/1 each); native Windows CI is running to confirm the formerly failing paths.