Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves AMD multi-node fixed-sequence benchmarks to srt-slurm and removes the legacy bash that coordinated them. Based on #3352, which moves single-node fixed-sequence.
runners/srt-slurm/hooks/<cluster>/setup.sh, run through the profile'sdefault_host_setup, with shared helpers inhooks/common.sh. MI355X gets its RDMA/QoS preflight, GPU drain gate, and hugepage reclaim; MI300X checks MEC firmware (177 or newer) instead of setting container environment in a preamble. Documented inAGENTS.mdanddocs/configuration-procedures.md.runners/launch_mi355x-amds.sh: multi-node jobs with aCONFIG_FILEsubmit the recipe throughapply_srt_recipewith the shared post-eval (eval runs drop fake expert dispatch), then collect results withcopy_fixed_sequence_results/copy_agentic_resultsand eval artifacts fromlogs/eval_results. The legacy multi-node path now only serves AgentX.runners/srt-slurm/mi355x-amds.yaml: adds the multi-node settings (fabric interface, output dir, model path, HF cache mounts, exporter and nginx settings) to refactor: migrate fixed-sequence recipes to SRT-Slurm / 将定长配方迁移至 SRT-Slurm #3352's profile.CONFIG_FILE. Recipes write results in the shared sa-bench layout.sglang-disaggandvllm-disaggto synthetic acceptance.amd_utilsvLLM and ATOM engine paths, the fixed-sequence bench client, and the per-model fixed-sequence server settings.Recipes own serving and workload settings; InferenceX does not rewrite them. Workflow settings reach custom benchmarks through the exported job environment.
AgentX configs (DeepSeek V4 DSpark, GLM-5.3 TileRT) stay on the legacy path until the AgentX migration.
Folds in #2628, #2629, #2631, #2633.