-
Notifications
You must be signed in to change notification settings - Fork 305
[AgentX][SGLang] Dsv4.1 update #3421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oasis-Git
wants to merge
7
commits into
main
Choose a base branch
from
config/dsv41flash-gb300-sglang-agentx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ff1804a
feat(gb300): add SGLang DeepSeek-V4.1 AgentX recipe
Oasis-Git f1fca89
refactor(gb300): keep Engram placement in benchmark recipe
Oasis-Git b01b8f3
merge: sync GB300 submission branch with main
Oasis-Git c265c55
perf(gb300): refresh SGLang image and tune TP4 AgentX prefill
Oasis-Git 0587fea
perf(gb300): use pure TP4 for low-concurrency AgentX points
Oasis-Git 77ae7ea
merge: resolve GB300 submission changelog conflict with main
Oasis-Git 2641baa
docs(gb300): shorten curve update notes
Oasis-Git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 TP4/EP1 C1 and C2 runs now silently pick up SGLANG_RAGGED_VERIFY_MODE=static, a setting the docs and changelog say is exclusive to TP4/EP4 C4+.
export SGLANG_RAGGED_VERIFY_MODE=staticat line 137 sits outside theif (( CONC > 2 ))block (line 138), so it applies to every TP==4 run, including the new EP1 C1 (CONC<=2) path added at line 52. docs/configuration-procedures.md lists only chunk 4096, interval 16, request cap 2, decode graph cap 64 and automatic SWA for TP4 C1, with static ragged verification scoped to "TP4/EP4 at C4 and above"; the C1/C2 measurements and the 450 vs 433 tok/s comparison in perf-changelog.yaml never varied this knob. …Why this was flagged
…Fix: move the
export SGLANG_RAGGED_VERIFY_MODE=staticline inside theif (( CONC > 2 ))block so it only applies where it was actually validated, keeping C1/C2 on whatever ragged-verify mode was previously in effect.Trigger: any TP==4 job (both the new EP1 C1/C2 entries in configs/nvidia-master.yaml and existing EP4 runs) executes lines 136-141. The code unconditionally exports SGLANG_RAGGED_VERIFY_MODE=static at line 137 before the CONC>2 gate at line 138, so C1/C2 EP1 runs get an untested serving mode never listed in docs/configuration-procedures.md's C1/C2 settings or in perf-changelog.yaml's description of the qualified config. On base, TP4 C1/C2 ran without this override. No safeguard catches the mismatch since the env var isn't included in SGLANG_CMD or written to sglang_command.txt/server.log filters that would flag it against the documented recipe.
Verification: normal. The claim is factually verified. In benchmarks/single_node/agentic/dsv41flash_fp4_gb300_sglang_mtp.sh,
export SGLANG_RAGGED_VERIFY_MODE=static(line 137) is placed insideif (( TP == 4 ))(line 136) but ABOVE theif (( CONC > 2 ))gate (line 138), so it executes for every TP4 run — including the new EP1 C1/C2 path (line 52:if (( TP == 4 && CONC <= 2 ))). All the other C4+…