config(minimaxm3): update GB200 Dynamo vLLM AgentX recipes / 更新 GB200 Dynamo vLLM AgentX 配方 - #3424
RohitNagraj wants to merge 2 commits into
Conversation
更新 MiniMax-M3 GB200 聚合与分离部署的 Dynamo vLLM AgentX 配方,并同步主配置和性能变更日志。
|
Thanks for the contribution!
中文感谢你的贡献!
|
补充 MiniMax-M3 GB200 配置提交的公开拉取请求链接。
There was a problem hiding this comment.
Beyond the inline pr-link finding, I also checked whether the decode max-num-seqs cap being far below each recipe's benchmarked concurrency was a bug (e.g. disagg-1p5d-dep4-tp2-mns4-c50.yaml: max-num-seqs 4 x 5 workers = 20 cap vs c50). Ruled out as unintentional: the same undersized-cap-vs-concurrency pattern appears consistently across all three new disagg recipes, and each filename literally encodes the chosen mns (max-num-seqs) value alongside its concurrency point(s) (mns1-c15, mns2-c20-c30, mns4-c50), which reads as a deliberate queuing/backpressure scheduler-cap design rather than a mismatch.
Extended reasoning...
This is a config/recipe-only PR (5 new srt-slurm YAML recipes plus matching master-config and changelog entries for the MiniMax-M3 GB200 FP4 benchmark matrix); it touches no application code and no auth/crypto/permissions surface. A confirmed inline finding already flags that the new perf-changelog.yaml entry's pr-link: TBD is not in the tool's accepted placeholder set (only "XXX" and its full URL form), so it will fail validate_added_pr_link in infx/workflows/validate_perf_changelog.py and block the changelog gate rather than pass as the PR description claims. I additionally checked the decode scheduler-cap-vs-concurrency pattern across all three new disagg recipes and found it consistent and filename-encoded, so I ruled that out as an intentional design choice rather than a separate bug. Given the confirmed blocking finding, this should not be approved.
| - "Pin each checked-in recipe to its declared vLLM, Dynamo, and Mooncake runtime, using the shipped EAGLE3 draft precision and real verification for evals." | ||
| - "新增 MiniMax-M3 GB200 聚合 TP4 SimpleCPU 配方变体,并分别设置调度上限;同时将分离部署搜索空间调整为 DEP4 prefill 与 TP2 decode 池。" | ||
| - "每个已检入配方固定其声明的 vLLM、Dynamo 与 Mooncake 运行时,使用 EAGLE3 草稿模型随附精度,并在评测中保留真实验证。" | ||
| pr-link: TBD |
There was a problem hiding this comment.
🔴 The new changelog entry's pr-link: TBD will make the merge-automation bot reject this PR's own changelog entry instead of canonicalizing it, unlike every other entry in the file. validate_added_pr_link in infx/workflows/validate_perf_changelog.py:134-143 only accepts a real https://github.com/SemiAnalysisAI/InferenceX/pull/<n> link or a placeholder in PR_LINK_PLACEHOLDERS = {"XXX", ".../pull/XXX"}; TBD matches neither and raises ChangelogValidationError("new PR entry must use ... or an XXX placeholder; found 'TBD'") when compare_entries runs (invoked from infx/workflows/prepare_perf_changelog_merge.py at merge time). Fix: use the documented XXX (or full pull/XXX URL) placeholder per CONTRIBUTING.md's example, not a free-form string like TBD.
Why this was flagged
The new perf-changelog.yaml entry at line 8901 sets pr-link: TBD. When the repo's merge-prep tooling (infx/workflows/prepare_perf_changelog_merge.py, via compare_entries/validate_added_pr_link) processes this PR to canonicalize appended entries' pr-link into the real PR URL, it calls validate_added_pr_link('TBD', pr_number). Since 'TBD' is not in PR_LINK_PLACEHOLDERS = {'XXX', 'https://github.com/SemiAnalysisAI/InferenceX/pull/XXX'} and does not match CANONICAL_PR_LINK, this raises ChangelogValidationError. CONTRIBUTING.md:190 documents the required placeholder as the literal 'XXX' form; grep across perf-changelog.yaml and the changelog_gate_tests fixtures shows every other placeholder entry uses 'XXX', never 'TBD'. This blocks the automated pr-link canonicalization/merge step for this PR, requiring a manual fix, whereas on the base branch every appended entry's placeholder is recognized and processed automatically.
Verification: normal. The new changelog entry at perf-changelog.yaml:8901 sets pr-link: TBD. The supported merge path utils/merge_with_reuse.sh:169-170 runs python3 -m infx.workflows.prepare_perf_changelog_merge canonicalize, which calls canonicalize_appended_links (prepare_perf_changelog_merge.py:77), which calls compare_entries(base, head, pr_number) at line 86. compare_entries iterates additions and…
Summary
Validation
srtctl dry-run -fsuccessfully for all 5 new recipes with the repository-pinnedsrt-slurmversion.git diff --check.Review notes
AI assistance
OpenAI GPT-5 (Codex; exact runtime version not exposed) prepared the configuration translation, validation, and pull request text. The submitter reviewed the resulting files and metadata before publication.
简体中文
概要
验证
srt-slurm版本,对 5 个新增配方执行srtctl dry-run -f,全部通过。git diff --check通过。审阅说明
AI 协助
OpenAI GPT-5(Codex;运行环境未公开更精确的版本标识)协助完成配置整理、验证与拉取请求文本。提交者会在发布前审阅最终文件和元数据。