Skip to content

[Refactor] Simplify buildSessionChoices with early return and map - #8447

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-declarative-session-choices-2754549279388059089
Closed

gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-declarative-session-choices-2754549279388059089

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

What this PR does

Refactors buildSessionChoices in packages/cli-kit/src/public/node/session-prompt.ts to replace imperative loop mutation with an early return guard clause and a declarative .map() transform.

How to test your changes?

CI


PR created automatically by Jules for task 2754549279388059089 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Sep 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. no-pr-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant