Skip to content

Require evidence for App Doctor OAuth scope findings - #8595

Open
lopez-mar wants to merge 1 commit into
mainfrom
lopez-mar/app-doctor-scope-evidence
Open

lopez-mar wants to merge 1 commit into
mainfrom
lopez-mar/app-doctor-scope-evidence

Conversation

@lopez-mar

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The OAuth-scope prompt treats missing local API references as evidence of excessive access. That can flag planned features, optional scopes, generated queries, and usage outside the reviewed directory without establishing a security problem. It also conflates local scope declarations with effective grants and unauthorized API access.

WHAT is this pull request doing?

Require concrete excess-authority evidence for SCOPE_OVER_REQUEST findings. Trace supported feature paths and exact API scope requirements, distinguish declared/requested/granted access, and keep incomplete evidence unresolved. Least-privilege cleanup remains useful guidance without automatically becoming a high-severity finding.

Update the versioned prompt, catalog guidance, and embedded source. This is independent of the route-auth cutover and #8591; it does not change finding or trace schemas.

How to manually test your changes?

pnpm shopify app doctor --path /path/to/app --json --skip-instructions
pnpm shopify app doctor instructions --path /path/to/app

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing and includes a patch changeset.

Assisted-By: devx/6a87267f-002b-45a7-a964-2b150210ff87
@lopez-mar
lopez-mar requested a review from a team as a code owner September 18, 2026 21:11
@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant