Skip null checks on required navigations and AsNoTracking before Select - #1428
Merged
Merged
Conversation
Verify.EntityFramework 16.0.0-beta.7 flags both patterns: - a null check on a required navigation, which EF translates to an always false comparison - AsNoTracking followed by Select, which has no effect Required-ness comes from the EF model. AsNoTracking now applies only when ApplyProjection adds no Select.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the main build failing after the bump to Verify.EntityFramework 16.0.0-beta.7, which flags two query patterns the library generated:
_.BaseEntity == null), which EF translates to0 = 1. The select projection now skips the check when the EF model marks the navigation required (NavigationReader.IsRequired). The flag is carried throughNavigationProjectionInfo, including on the filter requirement path.AsNoTracking()followed bySelect, which has no effect.IncludeAppender.ApplyProjectionnow takesdisableTrackingand only appliesAsNoTrackingwhen it adds noSelect.Navigationgains an optionalIsRequiredparameter, which is a small public API addition.There are 9 snapshot updates. Each one only removes a redundant null-check column from the SQL; the returned data is unchanged. The full test suite passes locally.