Skip to content

Add JPEG XL format, detector and libjxl-backed codec - #3222

Closed
Ram-Pavith wants to merge 1 commit into
SixLabors:mainfrom
Ram-Pavith:add-jpegxl-format
Closed

Ram-Pavith wants to merge 1 commit into
SixLabors:mainfrom
Ram-Pavith:add-jpegxl-format

Conversation

@Ram-Pavith

Copy link
Copy Markdown

Adds JPEG XL format support: JxlFormat, header detector (codestream FF 0A and container signatures), metadata, configuration module, and cjxl/djxl-backed encoder/decoder (ImageSharp has no managed JXL codec yet; only cjxl can also transcode legacy JPEG bit-exactly).

Registered in the default Configuration. New detector tests pass (3/3, dotnet test -f net10.0); library builds clean with .NET 10.

Note: PR #3153 is also working on JXL support; this smaller detector + libjxl-delegating codec is offered as an alternative/complement for discussion.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@JimBobSquarePants

Copy link
Copy Markdown
Member

I’m closing this PR. This approach is fundamentally incompatible with ImageSharp, and I am frustrated that it was submitted without respecting the project’s architecture or contribution process.

ImageSharp is a fully managed library. Launching native executables found on PATH, writing temporary files, and converting through PNG is not an acceptable implementation of JPEG XL support in this library. It defeats a core reason the library exists.

You removed the PR template rather than completing it. You also explicitly acknowledged #3153, which has been open since July. That contributor is undertaking the substantial work needed to implement JPEG XL within ImageSharp’s architecture. Offering an external command-line wrapper as a smaller alternative dismisses the requirements that make that work substantial.

This submission shows a lack of respect for the existing contributor’s work and for the maintainers’ time. Please read and follow the contribution requirements, understand the library’s design, and discuss proposals with the maintainers before submitting further work of this kind.

I will not accept this approach or review revisions intended to make it mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants