Skip to content

Fix hager driver delay - #3210

Merged
hcarter-775 merged 1 commit into
SmartThingsCommunity:mainfrom
JanJakubiszyn:hager-delay-fix
Sep 21, 2026
Merged

Fix hager driver delay#3210
hcarter-775 merged 1 commit into
SmartThingsCommunity:mainfrom
JanJakubiszyn:hager-delay-fix

Conversation

@JanJakubiszyn

@JanJakubiszyn JanJakubiszyn commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Fixed delay timing in Hager driver info_changed function.

Summary of Completed Tests

@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

matter-switch_coverage.xml

File Coverage
All files 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/aqara_cube/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/device_configuration.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/utils.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/utils.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_mk1/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/capability_handlers.lua 36% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua 80% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/event_handlers.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/eve_energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_garage_door/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/scroll_utils/event_utils.lua 52% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/scroll_handlers/event_handlers.lua 75% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/hager/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/attribute_handlers.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/capability_handlers.lua 10% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3f8f6e5

@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

   73 files    541 suites   0s ⏱️
3 269 tests 2 824 ✅ 0 💤 0 ❌ 445 🔥
5 258 runs  4 669 ✅ 0 💤 0 ❌ 589 🔥

For more details on these errors, see this check.

Results for commit 3f8f6e5.

♻️ This comment has been updated with latest results.

@JanJakubiszyn
JanJakubiszyn force-pushed the hager-delay-fix branch 2 times, most recently from 82cfe4f to 34dff1d Compare September 1, 2026 12:55
@JanJakubiszyn

JanJakubiszyn commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Hi @hcarter-775, Could you please review my quick fix to the Hager WAASYS driver?

Thank you!

@JanJakubiszyn
JanJakubiszyn force-pushed the hager-delay-fix branch 4 times, most recently from 34c3363 to 3781904 Compare September 15, 2026 07:20
KKlimczukS
KKlimczukS approved these changes Sep 15, 2026
View reviewed changes

@KKlimczukS KKlimczukS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JanJakubiszyn
Fix hager driver delay
3f8f6e5 
# Conflicts:
#	drivers/SmartThings/matter-switch/src/test/test_hager_waasys.lua
@hcarter-775
hcarter-775 merged commit 9309282 into SmartThingsCommunity:main Sep 21, 2026
24 of 28 checks passed
@JanJakubiszyn
JanJakubiszyn deleted the hager-delay-fix branch September 22, 2026 09:37
@JanJakubiszyn
JanJakubiszyn restored the hager-delay-fix branch September 23, 2026 14:28
@JanJakubiszyn JanJakubiszyn mentioned this pull request Sep 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KKlimczukS KKlimczukS KKlimczukS approved these changes
@hcarter-775 hcarter-775 hcarter-775 approved these changes
@cbaumler cbaumler Awaiting requested review from cbaumler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JanJakubiszyn @KKlimczukS @hcarter-775