SONARJAVA-7095 Implement JSON serialization for the common Spring context gathering model

[aurelien-coet-sonarsource]

---

Summary by Gitar

• New type adapters:
  • Added SpringContextGatheringModelTypeAdapter for serializing and deserializing Spring context gathering models
  • Added corresponding test suite in SpringContextGatheringModelTypeAdapterTest

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-7095

[asya-vorobeva]

💯

[gitar-bot]

Code Review ✅ Approved 1 closed / 1 findings

🟡 Medium risk · Serializing Spring context data across modules and files could omit bean or package metadata, producing incomplete context for subsequent analysis.

Implements JSON serialization for the Spring context gathering model with a custom SpringContextGatheringModelTypeAdapter to handle module and file-level context data. The @JsonAdapter bean round-trip issue under Gson's default null handling has been resolved, and comprehensive unit tests cover round-trips, missing properties, and empty modules. Ready to merge.

✅ 1 closed

✅ Bug: @JsonAdapter bean round-trip fails under Gson's default null handling

📄 java-frontend/src/main/java/org/sonar/java/model/springcontext/BeanDefinitionHolder.java:238 📄 java-frontend/src/main/java/org/sonar/java/serialization/SpringContextGatheringModelTypeAdapter.java:55-56
The new @JsonAdapter(BeanDefinitionHolderTypeAdapter.class) lets anyone call new Gson().toJson(bean) / fromJson(json, BeanDefinitionHolder.InputFileData.class) directly. The adapter's write relies on the caller having turned on serializeNulls. Today only SpringContextGatheringModelTypeAdapter.write does that (and possibly the cache helper's own writer). A default Gson writer has serializeNulls=false, so out.name(PROFILES).value((String) null) drops both the name and the value for every unconditional bean, and so does a null qualifier. read then throws missingProperty(PROFILES) because profilesRead stays false. That means the standalone round-trip this annotation advertises fails for the most common kind of bean (one with no @Profile). Fix: have BeanDefinitionHolderTypeAdapter.write save out.getSerializeNulls(), force it to true, and restore it in a finally, the same way the model adapter does. Alternatively, treat a missing profiles key as unconditional.

Review coverage

🧪 Functional validation 0 of 2 objectives covered

📋 Rules No rules evaluated

Cross-repo coverage 1 repository selected

Cross-repo inspection is incomplete. Unread code may contain additional impacts.

🤖 Auto-approval Not enabled · Set up

Implementation Status ◻️ 0 of 2 objectives covered

◻️ SONARJAVA-7095 - 0 of 2 objectives covered

This PR does not implement any of the stated objectives for Spring context model serialization or deserialization.

Other objectives on this issue, possibly covered elsewhere:

• ◻️ Implement on-disk serialization for the Spring context model
• ◻️ Implement on-disk de-serialization for the Spring context model

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
97.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube