Skip to content

feat(category-search): Improve Search Behaviour And Simplify API #955 - #960

Merged
mart-sessman merged 6 commits into
TEDI-Design-System:rcfrom
kristjan-prints-industry62:feat/955-category-search
Oct 14, 2026
Merged

mart-sessman merged 6 commits into
TEDI-Design-System:rcfrom
kristjan-prints-industry62:feat/955-category-search

Conversation

@kristjan-prints-industry62

Copy link
Copy Markdown
Contributor

Closes #955

CategorySearch needs clearer search feedback, better mobile presentation and more flexible sizing. This change also simplifies its public API and internal state handling.

Changes:

  • Show TEDI EmptyState when a successful search returns no results.
  • Display application-provided validation Alerts before or after the filter fields, separately for each category.
  • Reopen remembered results after selection and allow hiding the text-search button.
  • Hide previous results while a new search is running.
  • Add minimizeCounter to close the panel without clearing saved state or restoring focus.
  • Add a full-screen TEDI Modal on mobile. The supplied mobile value overrides the default below-md detection.
  • Add searchBarWidth and fullWidthFilterPanel, and keep the category selector width stable using the widest label.
  • Simplify implementation and tests, and update the Storybook examples and documentation.

Breaking changes and migration:

  • Remove open, categoryId, onOpenChange and onCategoryChange. defaultOpen and defaultCategoryId remain for initial values.
  • Rename panelWidth to textResultsPanelWidth.
  • Require at least one category and keep category IDs unchanged while mounted.
  • Clearing text leaves an empty query and removes saved results; it no longer restores initialQuery.
  • Below md, the component now uses the mobile modal by default. Set mobile={false} to retain the desktop presentation.

Validation:

  • ✅ Lint and TypeScript checks passed.
  • ✅ Library and Storybook builds passed.
  • ✅ Desktop and mobile examples checked.
  • ⚠️ Coverage: 152 suites passed; one Calendar test failed because it expects Jul 2025 but receives juuli 2025. CategorySearch tests passed.

…-Design-System#955

Add empty-state and validation feedback, remembered-result reopening,
optional search buttons and minimizeCounter support.

BREAKING CHANGE: Remove open, categoryId, onOpenChange and
onCategoryChange. Categories can no longer be added or removed after mounting.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: TEDI-Design-System/react/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 370c583e-b88a-402e-b761-676f81651faf
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tobre6
tobre6 requested a review from intermetric October 8, 2026 06:52
@mart-sessman
mart-sessman merged commit 80868d4 into TEDI-Design-System:rc Oct 14, 2026
7 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 14, 2026
# [20.0.0-rc.1](react-19.2.0-rc.9...react-20.0.0-rc.1) (2026-10-14)

### Features

* **category-search:** Improve Search Behaviour And Simplify API [#955](#955) ([#960](#960)) ([80868d4](80868d4))

### BREAKING CHANGES

* **category-search:** Remove open, categoryId, onOpenChange and
onCategoryChange. Categories can no longer be added or removed after mounting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CategorySearch]: Improve usability and simplify implementation

2 participants