feat(linux): add result grid context menu with Copy as and Export Results dialog - #2669
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adw::Dialog) with a format picker (CSV, JSON) and CSV options that match the macOS app: convert NULL to empty, convert line breaks to spaces, field names in first row, sanitize formula-like values, delimiter, quote mode, line break, decimal separator. Reset to Defaults. Options persist inpreferences.json.tablepro_core::exportwith unit tests. The oldrender_csvin the app went through the grid's display formatter, so it truncated text at 10k chars and wrote theNULLsentinel into files; the new path renders full values.serde_jsongetspreserve_orderso JSON output keeps column order.Deferred to follow-up PRs: Paste rows, Set Value > NOW() / CURRENT_TIMESTAMP (needs a raw SQL expression marker in the change tracker), SQL / Markdown / HTML / XML / XLSX file export.
Test plan
./scripts/ci-local.sh(fmt, clippy-D warnings, build, 338 unit tests; 21 new for the renderers)"and a=SUM(A1)value. Right-clicking on the editor result grid shows the read-only menu; on a table tab, it shows the full menu.preferences.jsonon change, Reset to Defaults restores defaults, Export writes the file and shows the toast. Output with semicolon + line breaks to spaces:2;has,comma;'-2.25;"line1 line2";falseand3;'=SUM(A1);10;"say ""hi""";false.tablepro-export-demo-3x.mp4
tablepro-export-demo-3x.mp4