Skip to content

refactor: reuse maintainer planning and review reads - #265

Merged
LadyBluenotes merged 1 commit into
feat-maintainer-interactive-reviewfrom
refactor-maintainer-read-reuse
Sep 11, 2026
Merged

LadyBluenotes merged 1 commit into
feat-maintainer-interactive-reviewfrom
refactor-maintainer-read-reuse

Conversation

@LadyBluenotes

Copy link
Copy Markdown
Member

🎯 Changes

Stacked on #263. Remove duplicate work within maintainer planning and source review. Closed #264 is not included.

  • Pass one parsed skill tree through registration, adoption, sync, and distribution helpers. Sync compares its updated tree with the original snapshot instead of rereading the file.
  • Reuse source hashes and resolved Git pathspec matches within each review report. Remove the single-use snapshot wrapper.
  • Keep fresh reads for later reports and recording, stale-plan rejection, path validation, locking, command output, and review-state format unchanged. No process-global cache, dependency, or guide changes.

The regression fixtures verify one skill-tree parse per sync. For two skills sharing a source pattern, source reads fall from 3 to 1 and matching Git queries from 4 to 2. The next report observes changed source bytes. These are operation counts, not latency benchmarks.

Verification

  • 71 focused maintainer, distribution, review, and review-workflow tests passed.
  • pnpm test passed build, types, Knip, Sherif, and docs checks, but hit five-second timeouts under parallel load in review-workflow and packed-release tests. No timeout or assertion was changed.
  • Serial reruns of both affected files passed all 21 tests with pnpm --dir packages/intent exec vitest run tests/review-workflow.test.ts tests/integration/packed-release.test.ts --no-file-parallelism.
  • ESLint passed after fixing the new tests' type imports, with eight existing warnings. Both duplicate-work regression tests, the final typecheck, Prettier, and git diff --check passed.
  • Live external-installer and native-host acceptance checks were not rerun; installer commands and generated metadata behavior are unchanged.

Related Work

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ee121354-349f-4c6c-84fc-588528d16928

📥 Commits

Reviewing files that changed from the base of the PR and between 3b50590 and 4c63c4e.

📒 Files selected for processing (10)
  • .changeset/reuse-maintainer-reads.md
  • packages/intent/src/commands/maintainer.ts
  • packages/intent/src/maintainer/add.ts
  • packages/intent/src/maintainer/adopt.ts
  • packages/intent/src/maintainer/distribution.ts
  • packages/intent/src/maintainer/project.ts
  • packages/intent/src/maintainer/sync.ts
  • packages/intent/src/review/review.ts
  • packages/intent/tests/distribution.test.ts
  • packages/intent/tests/review.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 11, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 549e5b8

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 45s View ↗
nx run-many --targets=build ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-11 04:57:51 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@265

commit: 549e5b8

@codspeed

codspeed Bot commented Sep 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing refactor-maintainer-read-reuse (4c63c4e) with feat-maintainer-interactive-review (422e4c2)

Open in CodSpeed

@LadyBluenotes
LadyBluenotes added this pull request to stack #274 September 11, 2026 22:02
@LadyBluenotes
LadyBluenotes force-pushed the refactor-maintainer-read-reuse branch 2 times, most recently from 5cd7b64 to 25b9ab9 Compare September 11, 2026 22:25
@LadyBluenotes
LadyBluenotes force-pushed the refactor-maintainer-read-reuse branch from 25b9ab9 to 4c63c4e Compare September 11, 2026 22:30
@LadyBluenotes
LadyBluenotes merged commit 5f56f22 into main Sep 11, 2026
7 of 9 checks passed
@LadyBluenotes
LadyBluenotes deleted the refactor-maintainer-read-reuse branch September 11, 2026 22:32
@github-actions github-actions Bot mentioned this pull request Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant