perf: reuse prepared SSR request locations by schiller-manuel · Pull Request #8441 · TanStack/router

schiller-manuel · 2026-09-15T21:37:49Z

🎯 Changes

Reuse the request location already prepared by the router during SSR. Server-route handling matches that parsed pathname instead of running the input rewrite again, while preserving encoded pathnames for handlers and middleware. SSR loading also skips the redundant location update; ordinary router loads retain their existing behavior.

Validation: affected unit, type, and lint checks passed, along with the server-routes Chromium tests. Regression coverage includes rewrites, encoded parameters, basepaths, mutable history, and route middleware.

The build-time shortcut for apps without server routes is a separate follow-up in #8444.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with the relevant test commands, or tests do not apply to this pull request.
I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

coderabbitai · 2026-09-15T21:39:11Z

Important

Review skipped

The saved review history does not include the base for the last reviewed commit. This saved history cannot establish the base for an incremental review. Comment @coderabbitai full review to establish a new review baseline. No full review was started, and the last reviewed checkpoint was preserved.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5879088e-e6c0-4f8d-9779-39a7c7f7c235

📥 Commits

Reviewing files that changed from the base of the PR and between b7600ee and 3df2769.

📒 Files selected for processing (19)

.changeset/polite-gifts-camp.md
packages/start-plugin-core/src/global.d.ts
packages/start-plugin-core/src/rsbuild/start-router-plugin.ts
packages/start-plugin-core/src/rsbuild/virtual-modules.ts
packages/start-plugin-core/src/start-manifest-plugin/manifestBuilder.ts
packages/start-plugin-core/src/start-router-plugin/generator-plugins/routes-manifest-plugin.ts
packages/start-plugin-core/src/start-router-plugin/pruneServerOnlySubtrees.ts
packages/start-plugin-core/src/vite/dev-server-plugin/plugin.ts
packages/start-plugin-core/src/vite/start-manifest-plugin/plugin.ts
packages/start-plugin-core/src/vite/start-router-plugin/plugin.ts
packages/start-plugin-core/tests/routes-manifest-plugin.test.ts
packages/start-plugin-core/tests/rsbuild/virtual-modules.test.ts
packages/start-plugin-core/tests/start-manifest-plugin.test.ts
packages/start-plugin-core/tests/start-manifest-plugin/manifestBuilder.test.ts
packages/start-server-core/src/createStartHandler.ts
packages/start-server-core/src/tanstack-start.d.ts
packages/start-server-core/tests/createStartHandler.test.ts
packages/start-server-core/tests/fixtures/start-manifest.ts
packages/start-server-core/tsconfig.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

SSR request handling now reuses the parsed request location. Server-route matching uses the prepared pathname, while handlers and middleware retain encoded pathnames. Build manifests now expose whether server routes exist.

Changes

SSR and server-route handling

Layer / File(s)	Summary
Reuse prepared SSR locations `packages/router-core/src/router.ts`, `packages/router-core/src/load-server.ts`, `packages/router-core/src/ssr/createRequestHandler.ts`, `packages/router-core/tests/server-history.test.ts`	SSR loads can skip location updates and reuse `latestLocation`. Tests cover rewrites, refreshes, search parsing, and loader data.
Track server-route availability `packages/start-plugin-core/src/start-router-plugin/`, `packages/start-plugin-core/src/start-manifest-plugin/`, `packages/start-plugin-core/src/vite/`, `packages/start-plugin-core/src/rsbuild/`	Route generation and manifest modules now carry `hasServerRoutes`. Build and development paths provide fallback values.
Update server request flow `packages/start-server-core/src/createStartHandler.ts`, `packages/start-server-core/src/tanstack-start.d.ts`	The handler reuses early-hints router instances, skips server-route matching when the manifest reports no server routes, avoids unconfigured middleware, and preserves encoded handler pathnames.
Validate routing and manifest behavior `packages/start-plugin-core/tests/`, `packages/start-server-core/tests/`, `.changeset/polite-gifts-camp.md`	Tests cover manifest detection, virtual modules, rewrites, origins, early hints, cancellation, and encoded parameters. The changeset declares patch releases.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Refactor

Sequence Diagram(s)

sequenceDiagram
  participant Request
  participant createStartHandler
  participant Router
  participant ServerMiddleware
  Request->>createStartHandler: submit SSR request
  createStartHandler->>Router: prepare or reuse latestLocation
  createStartHandler->>ServerMiddleware: run configured middleware
  ServerMiddleware->>Router: getMatchedRoutes(location.pathname)
  createStartHandler->>Router: load(_skipLocationUpdate: true)
  Router-->>createStartHandler: return loaded route data

Suggested reviewers: sheraff

Merge Risk: ⚪ Minimal · up to 3df27

The SSR request-location and server-route manifest changes retain their documented routing, rewrite, and fallback behavior. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 15.63% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 32 functions across 21 files. (2 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: reusing prepared SSR request locations.
Description check	✅ Passed	The description follows the required template, explains the changes and motivation, documents validation, completes the checklist, and records the changeset release impact.

Full details: Docstring Coverage

Explanation

Docstring coverage is 15.63% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 32 functions across 21 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/reuse-ssr-request-location

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-09-15T21:41:49Z

View your CI Pipeline Execution ↗ for commit b5c4ee7

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	14m 53s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 59s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-25 20:30:04 UTC

github-actions · 2026-09-15T21:42:11Z

🚀 Changeset Version Preview

6 package(s) bumped directly, 17 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/react-router`	1.170.39 → 1.170.40	Changeset
`@tanstack/router-core`	1.171.32 → 1.171.33	Changeset
`@tanstack/solid-router`	1.170.36 → 1.170.37	Changeset
`@tanstack/start-client-core`	1.170.32 → 1.170.33	Changeset
`@tanstack/start-server-core`	1.169.37 → 1.169.38	Changeset
`@tanstack/vue-router`	1.170.35 → 1.170.36	Changeset
`@tanstack/react-start`	1.168.58 → 1.168.59	Dependent
`@tanstack/react-start-client`	1.168.37 → 1.168.38	Dependent
`@tanstack/react-start-rsc`	0.1.57 → 0.1.58	Dependent
`@tanstack/react-start-server`	1.167.44 → 1.167.45	Dependent
`@tanstack/router-cli`	1.167.38 → 1.167.39	Dependent
`@tanstack/router-generator`	1.167.38 → 1.167.39	Dependent
`@tanstack/router-plugin`	1.168.40 → 1.168.41	Dependent
`@tanstack/router-vite-plugin`	1.167.40 → 1.167.41	Dependent
`@tanstack/solid-start`	1.168.55 → 1.168.56	Dependent
`@tanstack/solid-start-client`	1.168.35 → 1.168.36	Dependent
`@tanstack/solid-start-server`	1.167.42 → 1.167.43	Dependent
`@tanstack/start-plugin-core`	1.171.47 → 1.171.48	Dependent
`@tanstack/start-static-server-functions`	1.167.37 → 1.167.38	Dependent
`@tanstack/start-storage-context`	1.167.34 → 1.167.35	Dependent
`@tanstack/vue-start`	1.168.54 → 1.168.55	Dependent
`@tanstack/vue-start-client`	1.167.38 → 1.167.39	Dependent
`@tanstack/vue-start-server`	1.167.42 → 1.167.43	Dependent

github-actions · 2026-09-15T21:43:39Z

Bundle Size Benchmarks

This pull request does not affect bundle size in any measured scenario.

pkg-pr-new · 2026-09-15T21:45:12Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8441

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8441

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8441

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8441

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8441

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8441

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8441

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8441

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8441

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8441

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8441

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8441

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8441

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8441

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8441

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8441

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8441

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8441

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8441

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8441

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8441

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8441

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8441

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8441

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8441

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8441

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8441

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8441

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8441

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8441

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8441

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8441

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8441

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8441

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8441

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8441

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8441

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8441

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8441

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8441

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8441

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8441

commit: b5c4ee7

codspeed · 2026-09-15T21:57:50Z

Merging this PR will degrade performance by 24.29%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 188 untouched benchmarks
⏩ 3 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Memory	`mem server streaming-peak chunked (react)`	349.3 KB	642.7 KB	-45.64%
❌	Memory	`mem server request-churn (react)`	856 KB	1,110.9 KB	-22.95%
⚡	Memory	`mem server error-paths unmatched (react)`	889.3 KB	858.3 KB	+3.62%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing codex/reuse-ssr-request-location (b5c4ee7) with main (bb4423e)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions Bot added package: router-core package: start-server-core labels Sep 15, 2026

schiller-manuel requested a review from Sheraff September 15, 2026 21:57

Sheraff approved these changes Sep 15, 2026

View reviewed changes

schiller-manuel commented Sep 15, 2026

View reviewed changes

Comment thread packages/start-server-core/src/createStartHandler.ts

github-actions Bot added the package: start-plugin-core label Sep 15, 2026

schiller-manuel changed the title ~~perf: reuse prepared SSR request locations~~ perf: avoid redundant SSR routing work Sep 15, 2026

schiller-manuel force-pushed the codex/reuse-ssr-request-location branch from 3df2769 to b7600ee Compare September 15, 2026 23:04

schiller-manuel mentioned this pull request Sep 15, 2026

perf: skip unused Start server routing work #8444

Open

4 of 5 tasks

schiller-manuel changed the title ~~perf: avoid redundant SSR routing work~~ perf: reuse prepared SSR request locations Sep 15, 2026

schiller-manuel added this pull request to stack #8445 September 15, 2026 23:05

schiller-manuel force-pushed the codex/reuse-ssr-request-location branch 2 times, most recently from 5727d34 to 832a8a0 Compare September 16, 2026 21:11

perf: reuse prepared SSR request locations

b5c4ee7

schiller-manuel force-pushed the codex/reuse-ssr-request-location branch from 832a8a0 to b5c4ee7 Compare September 25, 2026 20:13

Navigation Menu

Repository navigation

perf: reuse prepared SSR request locations - #8441

perf: reuse prepared SSR request locations#8441
schiller-manuel wants to merge 1 commit into
mainfrom
codex/reuse-ssr-request-location

schiller-manuel commented Sep 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 15, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

schiller-manuel commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

coderabbitai Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

github-actions Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

pkg-pr-new Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 24.29%

Performance Changes

Footnotes

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

schiller-manuel commented Sep 15, 2026 •

edited

Loading

coderabbitai Bot commented Sep 15, 2026 •

edited

Loading

nx-cloud Bot commented Sep 15, 2026 •

edited

Loading

github-actions Bot commented Sep 15, 2026 •

edited

Loading

github-actions Bot commented Sep 15, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 15, 2026 •

edited

Loading

codspeed Bot commented Sep 15, 2026 •

edited

Loading