Repository navigation
feat(core): add compare util #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harry-whorlow
wants to merge
27
commits into
TanStack:main
Choose a base branch
from
harry-whorlow:evaluate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,171
−118
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6f26046
feat(core): add evaluate util
harry-whorlow 5c9612a
chore: pr comment
harry-whorlow b436a80
ci: apply automated fixes and generate docs
autofix-ci[bot] 31a570c
chore: protect against mixed inputs
harry-whorlow 0fe9052
ci: apply automated fixes and generate docs
autofix-ci[bot] 50628e1
chore: split mode
harry-whorlow 194eab9
fix: circular references
harry-whorlow 2c9d221
ci: apply automated fixes and generate docs
autofix-ci[bot] a5d59a1
fix: symbol keys eval
harry-whorlow 14efb5e
fix: unstub cleanup
harry-whorlow 4c5120f
chore: update tests
harry-whorlow 06f8762
ci: apply automated fixes and generate docs
autofix-ci[bot] 6352e9c
fix: file test
harry-whorlow ee3609e
ci: apply automated fixes and generate docs
autofix-ci[bot] fe24280
chore: rename
harry-whorlow 913bf8e
fix: subclass instances
harry-whorlow 71b2aa0
ci: apply automated fixes and generate docs
autofix-ci[bot] f788666
Merge branch 'main' into evaluate
KevinVandy 29d88b6
Merge remote-tracking branch 'origin/main' into evaluate
harry-whorlow 1ac124e
Merge branch 'main' into evaluate
harry-whorlow d00d4bf
ci: apply automated fixes and generate docs
autofix-ci[bot] 85658a4
chore: evaluate temporal
harry-whorlow 85b3a1e
chore: split to imperative functions
harry-whorlow 2f4c232
fix: bump node to 26
harry-whorlow 2151a8c
ci: apply automated fixes and generate docs
autofix-ci[bot] aca5f83
fix: temporal types
harry-whorlow bb4f118
ci: apply automated fixes and generate docs
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 24.8.0 | ||
| 26.10.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| id: compareDeep | ||
| title: compareDeep | ||
| --- | ||
|
|
||
| ```ts | ||
| function compareDeep<T>(objA, objB): boolean; | ||
| ``` | ||
|
|
||
| Defined in: [compare.ts:5](https://github.com/TanStack/store/blob/main/packages/store/src/compare.ts#L5) | ||
|
|
||
| ## Type Parameters | ||
|
|
||
| ### T | ||
|
|
||
| `T` | ||
|
|
||
| ## Parameters | ||
|
|
||
| ### objA | ||
|
|
||
| `T` | ||
|
|
||
| ### objB | ||
|
|
||
| `T` | ||
|
|
||
| ## Returns | ||
|
|
||
| `boolean` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| id: compareShallow | ||
| title: compareShallow | ||
| --- | ||
|
|
||
| ```ts | ||
| function compareShallow<T>(objA, objB): boolean; | ||
| ``` | ||
|
|
||
| Defined in: [compare.ts:1](https://github.com/TanStack/store/blob/main/packages/store/src/compare.ts#L1) | ||
|
|
||
| ## Type Parameters | ||
|
|
||
| ### T | ||
|
|
||
| `T` | ||
|
|
||
| ## Parameters | ||
|
|
||
| ### objA | ||
|
|
||
| `T` | ||
|
|
||
| ### objB | ||
|
|
||
| `T` | ||
|
|
||
| ## Returns | ||
|
|
||
| `boolean` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to split this into a new pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lmk when you do and we can get this one in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidkpiano its already done its living over in the pr