Added is_kebab_case utility in string class - #12206
Open
suryapratapsinghsuryavanshi wants to merge 3 commits into
Open
suryapratapsinghsuryavanshi wants to merge 3 commits into
suryapratapsinghsuryavanshi wants to merge 3 commits into
Conversation
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution, @suryapratapsinghsuryavanshi. One correctness issue worth fixing before this can land:
re.match only anchors at the start of the string, so trailing junk slips through:
>>> is_kebab_case("variable-name!!!")
True # should be FalseUse re.fullmatch (or add a $ anchor) so the whole string must match. While you are at it, you can drop the separate "_" not in var_name guard and the \w hack by matching lowercase kebab directly, which also correctly rejects Variable-Name (kebab-case is conventionally lowercase):
return bool(re.fullmatch(r"[a-z0-9]+(?:-[a-z0-9]+)+", var_name))Could you also add doctests for the trailing-character case and an uppercase input? Happy to re-review once updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: