I'm getting the following deprecation warning when running the library on PHP 8:
Deprecated: MysqliDb::insertMulti(): Implicitly marking parameter $dataKeys as nullable is deprecated, the explicit nullable type must be used instead in ... on line 850
Affected code (line 850):
public function insertMulti($tableName, array $multiInsertData, array $dataKeys = null)
Important note:
I installed this library via Composer, and the issue exists in the Composer-installed version. However, it appears that this problem has already been fixed in the GitHub repository (the source code on GitHub seems to already use the explicit nullable syntax). This means the fix has not yet been released to Packagist / the Composer package, so users installing via Composer are still affected.
Suggested fix (already applied on GitHub, needs a new release):
public function insertMulti($tableName, array $multiInsertData, ?array $dataKeys = null)
Request:
Could you please tag a new release and publish it to Packagist so that Composer users also receive this fix? Currently, the only workaround for Composer users is to manually patch the file in vendor/, which gets overwritten on every composer update.
Thank you!
I'm getting the following deprecation warning when running the library on PHP 8:
Affected code (line 850):
Important note:
I installed this library via Composer, and the issue exists in the Composer-installed version. However, it appears that this problem has already been fixed in the GitHub repository (the source code on GitHub seems to already use the explicit nullable syntax). This means the fix has not yet been released to Packagist / the Composer package, so users installing via Composer are still affected.
Suggested fix (already applied on GitHub, needs a new release):
Request:
Could you please tag a new release and publish it to Packagist so that Composer users also receive this fix? Currently, the only workaround for Composer users is to manually patch the file in
vendor/, which gets overwritten on everycomposer update.Thank you!