fix(preview): preserve typography when switching languages - #257
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting Japanese or Korean applied interface-language CSS to every Markdown preview, changing letter spacing, line height, text justification, wrapping, and heading weight even for English documents and release notes. Remove those overrides from the shared and bundled desktop stylesheets so switching languages preserves the normal document typography.
Add regression coverage for Japanese/Korean switching in both orders, returning to English, document reloads, frontmatter, tables, headings, mixed Japanese/Korean text, and release notes. Document the typography behavior in the localization guide.
Validation:
npm test: static/SEO checks and all 186 Chromium tests passed.npx playwright test tests/e2e/smoke.spec.js tests/e2e/localization-typography.spec.js: all 18 checks passed across Chromium, Firefox, and WebKit.git diff --checkpasses.